Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable watchman by default. #9714

Merged

Conversation

stuhood
Copy link
Member

@stuhood stuhood commented May 7, 2020

Problem

Using the notify crate for file invalidation is now feature complete, and so we are using two file watching implementations simultaneously under pantsd.

Solution

Disable watchman by default, and deprecate it. Additionally, remove the implementation of the experimental flag from notify. Fixes #8710, fixes #8198, fixes #7375, fixes #5487, fixes #4999, fixes #3479.

Stu Hood added 2 commits May 6, 2020 22:05
# Delete this line to force CI to run the JVM tests.
[ci skip-jvm-tests]
src/python/pants/option/global_options.py Outdated Show resolved Hide resolved
src/python/pants/option/global_options.py Outdated Show resolved Hide resolved
@@ -1063,6 +1064,8 @@ def validate_instance(cls, opts):
Raises pants.option.errors.OptionsError on validation failure.
"""
if opts.get("loop") and not opts.enable_pantsd:
# TODO: This remains the case today because there are two spots that
# call `run_goal_rules`: fixing in a followup.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@stuhood stuhood merged commit 5fd31ec into pantsbuild:master May 7, 2020
@stuhood stuhood deleted the stuhood/disable-watchman-by-default branch May 7, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants