Fix source root stripping to not strip requirements.txt files in plugins
#11712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ugins # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Right back at you, excellent modeling with |
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PythonRequirementsFileSourcesis like afiles()target in that its source roots should not be stripped. However, in #9640, we "fixed" it to not subclassFilesSourcesbecause this was causing lots of issues with the file being unintentionally included in chroots. Yet, as a result, usingawait Get(StrippedSourceFiles)will try to strip the file, unless the plugin author usesfor_sources_typeand leaves off the type in the allowlist.This PR allows us to properly handle both use cases by generifying the mechanism for "unrooted sources". Now, any
Sourcessubclass can express whether it uses source roots, i.e. it's no longer hardcoded toFilesSources.[ci skip-rust]
[ci skip-build-wheels]