Simplify excluding the requirements.txt file generated from python_requirements()
#9640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-jvm-tests] [ci skip-rust-tests]
Eric-Arellano
force-pushed
the
python-reqs
branch
from
57b3741
to
5340f74
Compare
stuhood
approved these changes
Apr 28, 2020
Eric-Arellano
added a commit
that referenced
this pull request
Mar 17, 2021
…ugins (#11712) The `PythonRequirementsFileSources` is like a `files()` target in that its source roots should not be stripped. However, in #9640, we "fixed" it to not subclass `FilesSources` because this was causing lots of issues with the file being unintentionally included in chroots. Yet, as a result, using `await Get(StrippedSourceFiles)` will try to strip the file, unless the plugin author uses `for_sources_type` and leaves off the type in the allowlist. This PR allows us to properly handle both use cases by generifying the mechanism for "unrooted sources". Now, any `Sources` subclass can express whether it uses source roots, i.e. it's no longer hardcoded to `FilesSources`. [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We never want to include the generated
requirements.txtcreated bypython_requirements().Previously, we had to explicitly exclude it because we had
PythonRequirementsFileSourcessubclassFilesSources. There was no good reason for this. Instead, it can simply subclassSourcesso be a stand-alone type.[ci skip-jvm-tests]
[ci skip-rust-tests]