Add macos workaround to build wheel step on macos. #11864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
slack discussion: https://pantsbuild.slack.com/archives/C0D7TNJHL/p1617914862144100 |
jsirois
approved these changes
Apr 8, 2021
|
It was failing from a lint error. I pushed a fix and tweaked some of the factoring. |
Merged
wisechengyi
added a commit
that referenced
this pull request
Apr 11, 2021
### Internal * [internal] Setup toolchain auth for build-wheels jobs too. ([#11875](#11875)) * Disable remote cache in CI when building wheels and bootstrapping Pants ([#11874](#11874)) * Hotfix build wheels jobs failing due to new Shell backend ([#11855](#11855)) * Deflake tar extraction by setting the cwd through the engine ([#11867](#11867)) * [internal] Add timeouts on some pants runs that can take a long time. ([#11870](#11870)) * Switch to new Toolchain remote cache proxy ([#11820](#11820)) * Show debug level logs in dynamic UI ([#11873](#11873)) * Remove deprecated `MockConsole` ([#11871](#11871)) * Remove deprcated `PantsEnvironment` type ([#11823](#11823)) * Simplify `generate_github_workflow.py` ([#11866](#11866)) * [internal] Upgrade toolchain plugin to v0.8.1 ([#11861](#11861)) * Add macOS workaround to build wheels step ([#11864](#11864)) * Prepare 2.4.0rc2 ([#11865](#11865)) * Add `--remote-cache-warnings` and make remote cache warnings less chatty ([#11859](#11859)) * [internal] Upload pants logs and make them available as artifacts ([#11860](#11860)) * [internal] Load toolchain auth token in all GH events except PR ([#11853](#11853)) * Dogfood shfmt internally ([#11854](#11854)) * Prepare 2.4.0rc1 ([#11850](#11850)) * Prepare 1.30.5rc0. ([#11848](#11848)) * Rewrite Python linter tests to be more declarative ([#11828](#11828)) * Escape generated markdown values. ([#11841](#11841)) * Update tests away from deprecated MockConsole API ([#11834](#11834))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See: #11733
This issue now happens during wheel build: https://github.com/pantsbuild/pants/runs/2300092374?check_suite_focus=true#step:8:1129
Solution
Apply the same solution that we use for running other things on macos to the build wheels job.