Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify generate_github_workflow.py #11866

Merged
merged 4 commits into from
Apr 9, 2021

Conversation

Eric-Arellano
Copy link
Contributor

@Eric-Arellano Eric-Arellano commented Apr 9, 2021

Prework for #11858.

  • Set remote cache options in pants.ci.toml instead of via env var.
  • Directly return a Step instead of Sequence[Step] where possible.
  • Use loose Python versions rather than patch versions.
  • Factor up setting ARCHFLAGS on macOS.

This also adds a new step to explicitly set $PY and [python-setup].interpreter_constraints, which was necessary in #11858 to get the cron job to consistently use the correct Python.

@Eric-Arellano Eric-Arellano changed the title WIP: Simplify generate_github_workflow.py Simplify generate_github_workflow.py Apr 9, 2021
@Eric-Arellano Eric-Arellano marked this pull request as ready for review April 9, 2021 00:57
@Eric-Arellano Eric-Arellano merged commit 0c62a04 into pantsbuild:main Apr 9, 2021
@Eric-Arellano Eric-Arellano deleted the ci-cleanup branch April 9, 2021 01:50
@wisechengyi wisechengyi mentioned this pull request Apr 10, 2021
wisechengyi added a commit that referenced this pull request Apr 11, 2021
### Internal

* [internal] Setup toolchain auth for build-wheels jobs too. ([#11875](#11875))

* Disable remote cache in CI when building wheels and bootstrapping Pants ([#11874](#11874))

* Hotfix build wheels jobs failing due to new Shell backend ([#11855](#11855))

* Deflake tar extraction by setting the cwd through the engine ([#11867](#11867))

* [internal] Add timeouts on some pants runs that can take a long time. ([#11870](#11870))

* Switch to new Toolchain remote cache proxy ([#11820](#11820))

* Show debug level logs in dynamic UI ([#11873](#11873))

* Remove deprecated `MockConsole` ([#11871](#11871))

* Remove deprcated `PantsEnvironment` type ([#11823](#11823))

* Simplify `generate_github_workflow.py` ([#11866](#11866))

* [internal] Upgrade toolchain plugin to v0.8.1 ([#11861](#11861))

* Add macOS workaround to build wheels step ([#11864](#11864))

* Prepare 2.4.0rc2 ([#11865](#11865))

* Add `--remote-cache-warnings` and make remote cache warnings less chatty ([#11859](#11859))

* [internal] Upload pants logs and make them available as artifacts ([#11860](#11860))

* [internal] Load toolchain auth token in all GH events except PR ([#11853](#11853))

* Dogfood shfmt internally ([#11854](#11854))

* Prepare 2.4.0rc1 ([#11850](#11850))

* Prepare 1.30.5rc0. ([#11848](#11848))

* Rewrite Python linter tests to be more declarative ([#11828](#11828))

* Escape generated markdown values. ([#11841](#11841))

* Update tests away from deprecated MockConsole API ([#11834](#11834))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants