Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep for 2.7.0rc0 #12695

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Conversation

illicitonion
Copy link
Contributor

@illicitonion illicitonion commented Aug 29, 2021

Internal changes

  • Clean up the config parsing code. (#12678)

  • [internal] --generate-lockfiles-resolve does not determine PythonLockfileRequest for unspecified tools (#12692)

  • [internal] Add missing resources targets for default tool lockfiles (#12670)

  • [internal] Reorganize lockfile code to no longer be in backend/python/experimental (#12669)

  • [internal] Test that default tool lockfiles work on macOS (#12666)

  • [internal] Improve the error message for stale/invalid lockfiles (#12618)

  • [internal] Rename ./pants lock to ./pants generate-user-lockfile and ./pants tool-lock to ./pants generate-lockfiles (#12641)

  • [internal] Only run macOS tests in CI annotated with @pytest.mark.platform_specific_behavior (#12665)

  • [internal] Test that Python tools work with all expected interpreter versions (#12656)

  • [internal] Factor out a helper rule for setting up --resolve-all-constraints (#12630)

  • [internal] Add links to changelog and Twitter in Pants PyPI project page. (#12636)

  • [internal] Update CoC with proper markdown + https links. (#12637)

  • GitHub issue templates (#12617)

  • Register subsystems and target types by backend/plugin. (#12623)

  • [internal] Sort input requirements for LockfileMetadata (#12615)

  • [internal] Expect lockfile metadata to be defined (#12616)

  • Simplify subsystem registration. (#12620)

  • [internal] Use constants for magic strings <none> and <default> for tool lockfiles (#12613)

  • [internal] Refactor lockfile_metadata.py to be more class-based (#12611)

  • Embrace that help strings are markdown. (#12606)

  • Stop fetching a lockfile request just to figure out the requirements digest (#12607)

  • [internal] Refactor MyPy first party plugins (#12599)

  • [internal] Refactor MyPy config file setup (#12593)

  • [internal] use is_union() rather than union.is_instance(). (#12595)

  • fs_util can use mTLS and ignore certificates (#12586)

  • [internal] Fix Pylint lockfile to actually be wired up (#12590)

  • [internal] Update lockfile TODOs with current state of project (#12592)

  • [internal] Check for lockfile staleness by using context's interpreter constraints, rather than global constraints (#12566)

  • [internal] Refactor Pylint first-party plugins (#12583)

  • [internal] Fix Pytest and IPython to check for stale lockfiles (#12582)

  • [internal] Do not cache lockfile generation (#12674)

Copy link
Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Eric-Arellano
Copy link
Contributor

Thanks! I figured it would be easier to send my feedback as a diff, given how much it is:

diff --git a/src/python/pants/notes/2.7.x.md b/src/python/pants/notes/2.7.x.md
index d74b4868a..b6791e19f 100644
--- a/src/python/pants/notes/2.7.x.md
+++ b/src/python/pants/notes/2.7.x.md
@@ -4,65 +4,43 @@
 
 ### New Features
 
-* Docker build rules. ([#12467](https://github.com/pantsbuild/pants/pull/12467))
-
-* Add `debian_package` target with boilerplate rule ([#12481](https://github.com/pantsbuild/pants/pull/12481))
-
-* Consume CoarsenedTargets (added in #12251) in javac for cycle resolution, including cycles created by subtargets. ([#12231](https://github.com/pantsbuild/pants/pull/12231))
-
-* Add tool lockfile for MyPy ([#12602](https://github.com/pantsbuild/pants/pull/12602))
+* Add `[tool].lockfile` (e.g. `[black].lockfile`) for Python tools and activate `./pants generate-lockfiles` by default ([#12684](https://github.com/pantsbuild/pants/pull/12684))
 
-* [go] use generated go.mod for external modules without a go.mod ([#12621](https://github.com/pantsbuild/pants/pull/12621))
+* Add `--generate-lockfiles-resolve` to allow generating for only certain tools ([#12676](https://github.com/pantsbuild/pants/pull/12676))
 
-* Go: add target type to represent packages in third-party modules ([#12584](https://github.com/pantsbuild/pants/pull/12584))
+* Add `[generate-lockfiles].custom_command` ([#12687](https://github.com/pantsbuild/pants/pull/12687))
 
-* go: rule to download external Go modules ([#12574](https://github.com/pantsbuild/pants/pull/12574))
+* Add experimental Docker build rules. ([#12467](https://github.com/pantsbuild/pants/pull/12467))
 
 ### User API Changes
 
 * Use Pants's default tool lockfiles by default for Python tools like Black, Pytest, and Flake8 ([#12689](https://github.com/pantsbuild/pants/pull/12689))
 
-* Bump default for `pytest-cov` (`[pytest].extra_requirements`) and `[coverage-py].version` so both use `coverage 5.5` ([#12690](https://github.com/pantsbuild/pants/pull/12690))
-
-* Pin `GitPython==3.1.18` by default with Bandit to ensure yanked release isn't used in lockfile generation ([#12691](https://github.com/pantsbuild/pants/pull/12691))
-
-* Add `[generate-lockfiles].custom_command` ([#12687](https://github.com/pantsbuild/pants/pull/12687))
-
 * Set `[python-setup].invalid_lockfile_behavior` to `error` by default ([#12686](https://github.com/pantsbuild/pants/pull/12686))
 
-* Add `[tool].lockfile` (e.g. `[black].lockfile`) for Python tools and activate `./pants generate-lockfiles` by default ([#12684](https://github.com/pantsbuild/pants/pull/12684))
+* Bump default for `pytest-cov` (`[pytest].extra_requirements`) and `[coverage-py].version` so both use `coverage 5.5` ([#12690](https://github.com/pantsbuild/pants/pull/12690))
 
-* Add `--generate-lockfiles-resolve` to allow generating for only certain tools ([#12676](https://github.com/pantsbuild/pants/pull/12676))
+* Pin `GitPython==3.1.18` by default with Bandit to ensure yanked release isn't used in lockfile generation ([#12691](https://github.com/pantsbuild/pants/pull/12691))
 
 * Stop pinning `stevedore<3` by default for Bandit ([#12681](https://github.com/pantsbuild/pants/pull/12681))
 
-* Stop installing setuptools by default with Black, Flake8, Isort, and Yapf ([#12673](https://github.com/pantsbuild/pants/pull/12673))
-
-* go: add more package analysis fields for various types of sources ([#12660](https://github.com/pantsbuild/pants/pull/12660))
-
-* Align `Enriched*Result` colors, sigils, and log levels. ([#12645](https://github.com/pantsbuild/pants/pull/12645))
+* Stop installing `setuptools` by default with Black, Flake8, Isort, and Yapf ([#12673](https://github.com/pantsbuild/pants/pull/12673))
 
 * Stop using `[python-setup].requirements_constraints` when installing tools like Black and MyPy ([#12639](https://github.com/pantsbuild/pants/pull/12639))
 
-* Add special casing for '--javac-jdk=system' as a temporary hack for #12293. ([#12425](https://github.com/pantsbuild/pants/pull/12425))
-
-* Allow bypassing the generate_docs.py version prompt. ([#12609](https://github.com/pantsbuild/pants/pull/12609))
-
-* Switch log warning rendering to yellow. ([#12596](https://github.com/pantsbuild/pants/pull/12596))
-
 * Default to `my-dep-stubs` and `stubs-my-dep` being third-party type stubs ([#12598](https://github.com/pantsbuild/pants/pull/12598))
 
 * Type stubs should be registered as normal requirements, not in `[mypy].extra_requirements` ([#12597](https://github.com/pantsbuild/pants/pull/12597))
 
 ### Plugin API Changes
 
-* support indivisible Sources fields ([#12685](https://github.com/pantsbuild/pants/pull/12685))
+* Support indivisible Sources fields ([#12685](https://github.com/pantsbuild/pants/pull/12685))
 
 * Render EngineAware parameters in cycle errors from Graph. ([#12668](https://github.com/pantsbuild/pants/pull/12668))
 
 * Split PexRequirements into three unioned types ([#12644](https://github.com/pantsbuild/pants/pull/12644))
 
-* add __repr__ impl for PySnapshot ([#12622](https://github.com/pantsbuild/pants/pull/12622))
+* Add `__repr__` impl for PySnapshot ([#12622](https://github.com/pantsbuild/pants/pull/12622))
 
 * Remove the `rationale` field from BashBinaryRequest. ([#12624](https://github.com/pantsbuild/pants/pull/12624))
 
@@ -74,18 +52,22 @@
 
 * tailor: do not append comma to kwarg with empty tuple ([#12653](https://github.com/pantsbuild/pants/pull/12653))
 
-* Fix Toolchain plugin being included in generated reference docs ([#12642](https://github.com/pantsbuild/pants/pull/12642))
-
 * Fix `FindBinary` when `which` is discoverable on `$PATH` on macOS ([#12581](https://github.com/pantsbuild/pants/pull/12581))
 
 * Fix coloring of stderr logs with pantsd ([#12585](https://github.com/pantsbuild/pants/pull/12585))
 
-* Fixes incorrectly-ordered sorting of requirement components in `InterpreterConstraints` constructor ([#12579](https://github.com/pantsbuild/pants/pull/12579))
-
 ### Performance
 
 * Decompose requirements pexes ([#12675](https://github.com/pantsbuild/pants/pull/12675))
 
+### Documentation
+
+* Switch log warning rendering to yellow. ([#12596](https://github.com/pantsbuild/pants/pull/12596))
+
+* Align `Enriched*Result` colors, sigils, and log levels. ([#12645](https://github.com/pantsbuild/pants/pull/12645))
+
+* Fix Toolchain plugin being included in generated reference docs ([#12642](https://github.com/pantsbuild/pants/pull/12642))
+
 ## 2.7.0.dev4 (Aug 15, 2021)
 
 ### New Features

I put all purely cosmetic/UI changes under "Documentation", which maybe should be retitled "Documentation / UI"

* Clean up the config parsing code. ([pantsbuild#12678](pantsbuild#12678))

* [internal] `--generate-lockfiles-resolve` does not determine `PythonLockfileRequest` for unspecified tools ([pantsbuild#12692](pantsbuild#12692))

* [internal] Add missing `resources` targets for default tool lockfiles ([pantsbuild#12670](pantsbuild#12670))

* [internal] Reorganize lockfile code to no longer be in `backend/python/experimental` ([pantsbuild#12669](pantsbuild#12669))

* [internal] Test that default tool lockfiles work on macOS ([pantsbuild#12666](pantsbuild#12666))

* [internal] Improve the error message for stale/invalid lockfiles ([pantsbuild#12618](pantsbuild#12618))

* [internal] Rename `./pants lock` to `./pants generate-user-lockfile` and `./pants tool-lock` to `./pants generate-lockfiles` ([pantsbuild#12641](pantsbuild#12641))

* [internal] Only run macOS tests in CI annotated with `@pytest.mark.platform_specific_behavior` ([pantsbuild#12665](pantsbuild#12665))

* [internal] Test that Python tools work with all expected interpreter versions ([pantsbuild#12656](pantsbuild#12656))

* [internal] Factor out a helper rule for setting up `--resolve-all-constraints` ([pantsbuild#12630](pantsbuild#12630))

* [internal] Add links to changelog and Twitter in Pants PyPI project page. ([pantsbuild#12636](pantsbuild#12636))

* [internal] Update CoC with proper markdown + https links. ([pantsbuild#12637](pantsbuild#12637))

* GitHub issue templates ([pantsbuild#12617](pantsbuild#12617))

* Register subsystems and target types by backend/plugin. ([pantsbuild#12623](pantsbuild#12623))

* [internal] Sort input requirements for `LockfileMetadata` ([pantsbuild#12615](pantsbuild#12615))

* [internal] Expect lockfile metadata to be defined ([pantsbuild#12616](pantsbuild#12616))

* Simplify subsystem registration. ([pantsbuild#12620](pantsbuild#12620))

* [internal] Use constants for magic strings `<none>` and `<default>` for tool lockfiles ([pantsbuild#12613](pantsbuild#12613))

* [internal] Refactor `lockfile_metadata.py` to be more class-based ([pantsbuild#12611](pantsbuild#12611))

* Embrace that help strings are markdown. ([pantsbuild#12606](pantsbuild#12606))

* Stop fetching a lockfile request just to figure out the requirements digest ([pantsbuild#12607](pantsbuild#12607))

* [internal] Refactor MyPy first party plugins ([pantsbuild#12599](pantsbuild#12599))

* [internal] Refactor MyPy config file setup ([pantsbuild#12593](pantsbuild#12593))

* [internal] use `is_union()` rather than `union.is_instance()`. ([pantsbuild#12595](pantsbuild#12595))

* fs_util can use mTLS and ignore certificates ([pantsbuild#12586](pantsbuild#12586))

* [internal] Fix Pylint lockfile to actually be wired up ([pantsbuild#12590](pantsbuild#12590))

* [internal] Update lockfile TODOs with current state of project ([pantsbuild#12592](pantsbuild#12592))

* [internal] Check for lockfile staleness by using context's interpreter constraints, rather than global constraints  ([pantsbuild#12566](pantsbuild#12566))

* [internal] Refactor Pylint first-party plugins ([pantsbuild#12583](pantsbuild#12583))

* [internal] Fix Pytest and IPython to check for stale lockfiles ([pantsbuild#12582](pantsbuild#12582))

* [internal] Do not cache lockfile generation ([pantsbuild#12674](pantsbuild#12674))
@illicitonion
Copy link
Contributor Author

Thanks @Eric-Arellano! Applied the patch, and updated to reflect the one commit since the PR went out

@illicitonion illicitonion merged commit b86d463 into pantsbuild:main Aug 30, 2021
@illicitonion illicitonion deleted the dwagnerhall/2.7.0rc0 branch August 30, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants