Add engine_error() context manager for testing plugin exceptions
#13108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Christopher Neugebauer <_@chrisjrn.com> [ci skip-rust] [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Conflicts: # src/python/pants/testutil/rule_runner.py # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust]
|
Oh hm! @kaos your suggestion means we can make this a lot simpler. Do we really need to allow inspecting trap.e after the context manager? Instead, I think it's enough to rely on the expected_exception_type and contains args. That allows us to switch to a function-based context manager. |
Hah, true! :) |
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
changed the title
EngineErrorTrap for testing plugin exceptionsengine_error() context manager for testing plugin exceptions
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it much easier to test that we raise the appropriate exceptions in rule code.
Thanks to @chrisjrn for co-developing this.
[ci skip-rust]
[ci skip-build-wheels]