Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add engine_error() context manager for testing plugin exceptions #13108

Merged
merged 5 commits into from
Oct 5, 2021
Merged

Add engine_error() context manager for testing plugin exceptions #13108

merged 5 commits into from
Oct 5, 2021

Commits on Oct 4, 2021

  1. Add EngineErrorTrap for testing plugin exceptions 

    Co-authored-by: Christopher Neugebauer <_@chrisjrn.com>

[ci skip-rust]

[ci skip-build-wheels]
    @Eric-Arellano
    Eric-Arellano committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    da89e90 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2021

  1. Review feedback 

    # Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
    @Eric-Arellano
    Eric-Arellano committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    0a24396 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:pantsbuild/pants into engine-error 

    # Conflicts:
#	src/python/pants/testutil/rule_runner.py

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]
    @Eric-Arellano
    Eric-Arellano committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    0a073b7 View commit details
    Browse the repository at this point in the history

  3. Simplify: use function-based engine_error() rather than class 

    # Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
    @Eric-Arellano
    Eric-Arellano committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    8b422c4 View commit details
    Browse the repository at this point in the history

  4. Bad copy pasta 

    # Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
    @Eric-Arellano
    Eric-Arellano committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    f1f3e3f View commit details
    Browse the repository at this point in the history