[internal] remove java/scala codegen backends that are not ready for release #14351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can be reverted for 2.11 once we branch for 2.10. |
tdyas
pushed a commit
that referenced
this pull request
Feb 7, 2022
#14351 removed Java/Scala codegen backends temporarilly to ensure they were not released with 2.10. That PR was apparently incomplete. Removal of the `DefaultTool.jvm` entries for those backends is also necessary since those entries refer to the names of the removed backends.
tdyas
pushed a commit
to tdyas/pants
that referenced
this pull request
Feb 9, 2022
…ady for release (pantsbuild#14351)" This reverts commit caf8430. [ci skip-rust]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #14258, codegen backends for compiled languages do not currently work since the core codegen rules only supporting generating sources, but not generating targets to allow the backends for compiled languages to actually compile the sources.
For now, remove the registration code for those backends so users do not try to use them.