Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal] remove java/scala codegen backends that are not ready for release #14351

Merged
merged 1 commit into from
Feb 4, 2022

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Feb 3, 2022

As described in #14258, codegen backends for compiled languages do not currently work since the core codegen rules only supporting generating sources, but not generating targets to allow the backends for compiled languages to actually compile the sources.

For now, remove the registration code for those backends so users do not try to use them.

@tdyas
Copy link
Contributor Author

tdyas commented Feb 3, 2022

This can be reverted for 2.11 once we branch for 2.10.

Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tdyas tdyas merged commit caf8430 into pantsbuild:main Feb 4, 2022
@tdyas tdyas deleted the remove_not_ready_codegen_backends branch February 4, 2022 01:03
tdyas pushed a commit that referenced this pull request Feb 7, 2022
#14351 removed Java/Scala codegen backends temporarilly to ensure they were not released with 2.10. That PR was apparently incomplete. Removal of the `DefaultTool.jvm` entries for those backends is also necessary since those entries refer to the names of the removed backends.
tdyas pushed a commit to tdyas/pants that referenced this pull request Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants