[internal] fix code path in generate_all_lockfiles_helper #14379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-merge was automatically disabled
February 6, 2022 18:18
Head branch was pushed to by a user without write access
|
@Eric-Arellano had to remove them, the rename didn't work since the PR removed them and didn't just move them |
|
@tdyas fyi for when you revert the jvm codegen PR. |
tdyas
approved these changes
Feb 7, 2022
tdyas
changed the title
tdyas
pushed a commit
to tdyas/pants
that referenced
this pull request
Feb 9, 2022
…ntsbuild#14379)" This reverts commit 0ee3b04. [ci skip-rust]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14351 removed Java/Scala codegen backends temporarilly to ensure they were not released with 2.10. That PR was apparently incomplete. Removal of the
DefaultTool.jvmentries for those backends is also necessary since those entries refer to the names of the removed backends.