Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for parsing address parameters to CLI specs parsing (cherrypick of #14949) #14957

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Add support for parsing address parameters to CLI specs parsing (cherrypick of #14949) #14957

merged 1 commit into from
Mar 30, 2022

Commits on Mar 30, 2022

  1. Add support for parsing address parameters to CLI specs parsing (pant… 

    …sbuild#14949)

 pantsbuild#14347 added support for `Address` parameters, which are used via the `parametrize` builtin. But we had not yet added support for parsing parametrized addresses to CLI specs parsing.

This change adds support for parsing parametrized addresses in CLI specs by generalizing the parser that was added in pantsbuild#14346 to support parsing the additional syntax required for CLI specs (`!` ignores and `:`/`::` wildcards), and then using the same parser (with different validation) for both `Address` and `Specs` parsing.

Fixes pantsbuild#14521.

[ci skip-build-wheels]
    @stuhood
    stuhood committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    1bd670a View commit details
    Browse the repository at this point in the history