Dedupe load_bytes_with
calls to a remote Store (Cherry-pick of #15901)
#15915
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #15524:
remote::ByteStore::load_bytes_with
calls are not deduped currently, meaning that if multiple consumers identify aDigest
which is missing from the local store, they might concurrently fetch it from the remote store.This is primarily an issue with
--remote-cache-eager-fetch=false
, as the laziness means that all consumers of a process output might consider whether to download it simultaneously (rather than the output always being downloaded before the process is called complete).Fixes #15524.
[ci skip-build-wheels]