Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedupe load_bytes_with calls to a remote Store (Cherry-pick of #15901) #15915

Merged
merged 1 commit into from
Jun 24, 2022

Commits on Jun 24, 2022

  1. Dedupe load_bytes_with calls to a remote Store (pantsbuild#15901)

    As described in pantsbuild#15524: `remote::ByteStore::load_bytes_with` calls are not deduped currently, meaning that if multiple consumers identify a `Digest` which is missing from the local store, they might concurrently fetch it from the remote store.
    
    This is primarily an issue with `--remote-cache-eager-fetch=false`, as the laziness means that all consumers of a process output might consider whether to download it simultaneously (rather than the output always being downloaded before the process is called complete).
    
    Fixes pantsbuild#15524.
    
    [ci skip-build-wheels]
    stuhood committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    33a9b4f View commit details
    Browse the repository at this point in the history