Improve debugpy's capabilities #15946
Conversation
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
thejcannon
added
the
category:internal
| return ("-c", f"import {main.module};{main.module}.{main.function}();") | ||
| return ("-m", main.module) | ||
|
|
||
| assert isinstance(main, ConsoleScript) |
There was a problem hiding this comment.
It seems like this method should take a ConsoleScript so that the caller is forced to apply (and reason about) this assertion instead.
There was a problem hiding this comment.
Well either entrypoint or console script, I'll change the type to a union
There was a problem hiding this comment.
Actually, I think I'm going to leave it as-is. These are the only two subclasses of MainSpecification, and if I change it to use the union, the callsites needs to be casted or asserted, and neither is pretty.
There was a problem hiding this comment.
The assert is still happening: it's just hidden. IMO, that's a trap for the caller. But nbd.
There was a problem hiding this comment.
Yeah OK, thats fair. Past Josh was lazy, we should shun him.
- Adding an `args` flag for additional flags (especially useful for debug logs) - Adds support for executing module/module+function/console_script [ci skip-rust] [ci skip-build-wheels]
argsflag for additional flags (especially useful for debug logs)[ci skip-rust]
[ci skip-build-wheels]