-
-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare the 2.14.0.dev1 release. #16052
Conversation
[ci skip-rust]
Internal (put these in a PR comment for review, not the release notes)
|
I can repro the CI failures and the crazy thing is they bisect to this commit, which touches no source code. Working on it but definitely stumped at the moment. |
That is bizarre! |
FWIW I can repro this on this branch on macos |
And not on the prior commit. So, yeah. Weird as hell. |
Ah, somehow missed this: pants/src/python/pants/engine/internals/specs_rules.py Lines 468 to 493 in 27628c3
I'll get a PR out for that deprecation. |
You've probably already noticed this, but have confirmed that this is due to the change in VERSION, not the other files. Not sure why though. |
Changing the VERSION to, say, So, hypothesis: this has something to do with deprecations. |
The only deprecation I can find that seems relevant is
|
….dev1/release-prep [ci skip-rust]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust]
….dev1/release-prep [ci skip-rust]
….dev1/release-prep [ci skip-rust]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust]
This should go green, but trying to get it landed during working hours after the long weekend in Canada and in the US is going to be ~impossible. Lots of stuff is landing. I'll update once more with new lands this evening and then finish this out then. |
….dev1/release-prep [ci skip-rust]
[ci skip-rust]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust]
[ci skip-rust]