[internal] use CAS BatchReadBlobs API for small blob reads #15969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 28, 2022 14:34
[ci skip-build-wheels]
|
Note: The tests will need to be reworked to test both small and large blob paths. This could be done by directly calling the |
Eric-Arellano
approved these changes
Jun 28, 2022
|
Needs cherry-pick to 2.13? |
Eventually maybe but not today. I need to do a follow-up which properly invokes both the bath and stream paths in the tests. |
tdyas
pushed a commit
to tdyas/pants
that referenced
this pull request
Jun 29, 2022
…d#15969) In pantsbuild#12537, Pants learned how to send small blob writes to a remote store via the `BatchUpdateBlobs` API of the REAPI instead of the `ByteStream.Write` streaming API. This PR similarly teaches Pants how to use the `BatchReadBlobs` API for small blob reads instead of the `ByteStream.Read` API. The goal is to reduce the overhead of small blob reads by avoiding the multiple message exchanges required by the streaming API. Note: This PR does not batch multiple small blob reads together, which is an approach that could be worthwhile to evaluate in the future. # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
tdyas
pushed a commit
that referenced
this pull request
Jun 29, 2022
…ck of #15969) (#15997) In #12537, Pants learned how to send small blob writes to a remote store via the `BatchUpdateBlobs` API of the REAPI instead of the `ByteStream.Write` streaming API. This PR similarly teaches Pants how to use the `BatchReadBlobs` API for small blob reads instead of the `ByteStream.Read` API. The goal is to reduce the overhead of small blob reads by avoiding the multiple message exchanges required by the streaming API. Note: This PR does not batch multiple small blob reads together, which is an approach that could be worthwhile to evaluate in the future.
Merged
kaos
added a commit
to kaos/pants
that referenced
this pull request
Jun 30, 2022
…antsbuild#15969)" This reverts commit 5874884. This resolves and issue with running `./pants check` on more than just a few files.
tdyas
pushed a commit
to tdyas/pants
that referenced
this pull request
Jun 30, 2022
…antsbuild#15969)" This reverts commit 5874884. [ci skip-build-wheels]
tdyas
pushed a commit
to tdyas/pants
that referenced
this pull request
Jun 30, 2022
…herry-pick of pantsbuild#15969) (pantsbuild#15997)" This reverts commit bcbfda5. [ci skip-build-wheels]
tdyas
pushed a commit
that referenced
this pull request
Jun 30, 2022
Causes stack blowout due to the Future being too big. * Revert "[internal] test batch and stream API paths for load/store from remote store (#15996)" This reverts commit 2fa8671. [ci skip-build-wheels] * Revert "[internal] use CAS BatchReadBlobs API for small blob reads (#15969)" This reverts commit 5874884. [ci skip-build-wheels]
tdyas
pushed a commit
that referenced
this pull request
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #12537, Pants learned how to send small blob writes to a remote store via the
BatchUpdateBlobsAPI of the REAPI instead of theByteStream.Writestreaming API. This PR similarly teaches Pants how to use theBatchReadBlobsAPI for small blob reads instead of theByteStream.ReadAPI.The goal is to reduce the overhead of small blob reads by avoiding the multiple message exchanges required by the streaming API.
Note: This PR does not batch multiple small blob reads together, which is an approach that could be worthwhile to evaluate in the future.