[internal] test batch and stream API paths for load/store from remote store #15996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-build-wheels]
tdyas
pushed a commit
to tdyas/pants
that referenced
this pull request
Jun 30, 2022
…m remote store (pantsbuild#15996)" This reverts commit 2fa8671. [ci skip-build-wheels]
tdyas
pushed a commit
that referenced
this pull request
Jun 30, 2022
Causes stack blowout due to the Future being too big. * Revert "[internal] test batch and stream API paths for load/store from remote store (#15996)" This reverts commit 2fa8671. [ci skip-build-wheels] * Revert "[internal] use CAS BatchReadBlobs API for small blob reads (#15969)" This reverts commit 5874884. [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests that guarantee to invoke both the batch and stream API variants for loads and stores from a remote CAS. The other tests rely on the wrapper methods for load and store which select the API to use based on blob size. For full test coverage, both paths need to be tested, so make them
pub(crate)(since the tests are in a sibling module) and invoke directly.[ci skip-build-wheels]