Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debug output to help to differentiate retry cases #16277

Merged
merged 1 commit into from
Jul 23, 2022
Merged

Add debug output to help to differentiate retry cases #16277

merged 1 commit into from
Jul 23, 2022

Conversation

stuhood
Copy link
Member

@stuhood stuhood commented Jul 22, 2022 •
edited
Loading

This is debug output (and labels itself as such) to assist with differentiating the cases of #16096.

[ci skip-build-wheels]

@stuhood stuhood added the category:internal CI, fixes for not-yet-released features, etc. label Jul 22, 2022
@stuhood stuhood mentioned this pull request Jul 22, 2022
Open
jsirois
jsirois approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@jsirois jsirois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably this is not to really land but to just retry a few times in PR CI to get the log lines you need?

@stuhood
Copy link
Member Author

stuhood commented Jul 22, 2022

Presumably this is not to really land but to just retry a few times in PR CI to get the log lines you need?

I will definitely retry the PR runs a few times, and if it reproduces there then that will be wonderful and I'll skip landing. But if I can't reproduce in a timely manner, then I do hope to actually land this.

Feel free to veto though: I think that I can probably eventually repro with PR retries.

@jsirois
Copy link
Contributor

jsirois commented Jul 22, 2022

If landing has to be (I can't do the math in my head to say why can't you set up a CRON on your fork since I'm not sure that's actually easy), then so be it. I assume you'll give a loud warning 1st on #development that red CI on main is expected.

@stuhood
Copy link
Member Author

stuhood commented Jul 23, 2022 •
edited
Loading

I've had a few hours of retries in here, but it's fairly unlikely to repro on a single PR in a timely manner, since it can essentially only happen on a boundary where a portion of a cache entry has expired.

I'll land, and bump the notice in #development to "please definitely report issues on #16096 and feel free to set remote_cache_eager_fetch = true".

@stuhood stuhood enabled auto-merge (squash) July 23, 2022 02:27
@stuhood stuhood merged commit 1d88198 into pantsbuild:main Jul 23, 2022
@stuhood stuhood deleted the stuhood/test-loop-debug-output branch July 23, 2022 03:22
stuhood added a commit to stuhood/pants that referenced this pull request Jul 27, 2022
@stuhood
Add debug output to help to differentiate retry cases (pantsbuild#16277)
c164dd0 
This is debug output (and labels itself as such) to assist with differentiating the cases of pantsbuild#16096.

[ci skip-build-wheels]
@stuhood stuhood mentioned this pull request Jul 27, 2022
Closed
jyggen pushed a commit to jyggen/pants that referenced this pull request Jul 27, 2022
@stuhood @jyggen
Add debug output to help to differentiate retry cases (pantsbuild#16277)
2535bb0 
This is debug output (and labels itself as such) to assist with differentiating the cases of pantsbuild#16096.

[ci skip-build-wheels]
@stuhood stuhood mentioned this pull request Jul 28, 2022
Merged
stuhood added a commit to stuhood/pants that referenced this pull request Aug 2, 2022
@stuhood
Add debug output to help to differentiate retry cases (pantsbuild#16277)
72431b2 
This is debug output (and labels itself as such) to assist with differentiating the cases of pantsbuild#16096.

[ci skip-build-wheels]
stuhood added a commit to stuhood/pants that referenced this pull request Aug 2, 2022
@stuhood
Add debug output to help to differentiate retry cases (pantsbuild#16277)
fec1d29 
This is debug output (and labels itself as such) to assist with differentiating the cases of pantsbuild#16096.

[ci skip-rust]
[ci skip-build-wheels]
illicitonion added a commit to illicitonion/pants that referenced this pull request Aug 5, 2022
@illicitonion
Prep for 2.14.0.dev4
4a49250 
Internal changes:

* [internal] Replace `pkgutil.get_data` with new `read_resource` API ([pantsbuild#16379](pantsbuild#16379))

* Bump bytes from 1.2.0 to 1.2.1 in /src/rust/engine ([pantsbuild#16389](pantsbuild#16389))

* Bump arc-swap from 1.5.0 to 1.5.1 in /src/rust/engine ([pantsbuild#16390](pantsbuild#16390))

* Bump console from 0.15.0 to 0.15.1 in /src/rust/engine ([pantsbuild#16392](pantsbuild#16392))

* Fix incorrect alpha sorting of a maintainer name ([pantsbuild#16401](pantsbuild#16401))

* Add Borja Lorente to Maintainers Emeritus ([pantsbuild#16382](pantsbuild#16382))

* Clarify limited logo usage rights granted by orgs ([pantsbuild#16384](pantsbuild#16384))

* Move Nora Howard to Maintainers Emeritus ([pantsbuild#16383](pantsbuild#16383))

* Include Chris Livingston in Maintainers Emeritus ([pantsbuild#16374](pantsbuild#16374))

* Bump clap from 3.2.14 to 3.2.15 in /src/rust/engine ([pantsbuild#16309](pantsbuild#16309))

* Bump crossbeam-channel from 0.5.5 to 0.5.6 in /src/rust/engine ([pantsbuild#16308](pantsbuild#16308))

* remove spurious quote mark ([pantsbuild#16361](pantsbuild#16361))

* A script to generate known versions data for the terraform binary ([pantsbuild#15958](pantsbuild#15958))

* Add more otel packages to default module mapping + fix to always use tuples ([pantsbuild#16345](pantsbuild#16345))

* [internal] upgrade `async-trait` crate ([pantsbuild#16347](pantsbuild#16347))

* Log dirtied nodes while backtracking. ([pantsbuild#16342](pantsbuild#16342))

* Added Opentelemetry to default Python module mapping ([pantsbuild#16337](pantsbuild#16337))

* Upgrade Toolchain Pants Plugin to 0.21.0 ([pantsbuild#16324](pantsbuild#16324))

* Bump bytes from 1.1.0 to 1.2.0 in /src/rust/engine ([pantsbuild#16245](pantsbuild#16245))

* Bump nix from 0.24.1 to 0.24.2 in /src/rust/engine ([pantsbuild#16307](pantsbuild#16307))

* Fix macos-10.15 brownout. ([pantsbuild#16317](pantsbuild#16317))

* Bump hyper from 0.14.19 to 0.14.20 in /src/rust/engine ([pantsbuild#16164](pantsbuild#16164))

* Bump clap from 3.2.8 to 3.2.14 in /src/rust/engine ([pantsbuild#16269](pantsbuild#16269))

* Don't break builds when pants.log upload fails ([pantsbuild#16294](pantsbuild#16294))

* [internal] Shell completion support ([pantsbuild#16200](pantsbuild#16200))

* Add debug output to help to differentiate retry cases ([pantsbuild#16277](pantsbuild#16277))
@illicitonion illicitonion mentioned this pull request Aug 5, 2022
Merged
illicitonion added a commit to illicitonion/pants that referenced this pull request Aug 5, 2022
@illicitonion
Prep for 2.14.0.dev4
bb2e7dd 
Internal changes:

* [internal] Replace `pkgutil.get_data` with new `read_resource` API ([pantsbuild#16379](pantsbuild#16379))

* Bump bytes from 1.2.0 to 1.2.1 in /src/rust/engine ([pantsbuild#16389](pantsbuild#16389))

* Bump arc-swap from 1.5.0 to 1.5.1 in /src/rust/engine ([pantsbuild#16390](pantsbuild#16390))

* Bump console from 0.15.0 to 0.15.1 in /src/rust/engine ([pantsbuild#16392](pantsbuild#16392))

* Fix incorrect alpha sorting of a maintainer name ([pantsbuild#16401](pantsbuild#16401))

* Add Borja Lorente to Maintainers Emeritus ([pantsbuild#16382](pantsbuild#16382))

* Clarify limited logo usage rights granted by orgs ([pantsbuild#16384](pantsbuild#16384))

* Move Nora Howard to Maintainers Emeritus ([pantsbuild#16383](pantsbuild#16383))

* Include Chris Livingston in Maintainers Emeritus ([pantsbuild#16374](pantsbuild#16374))

* Bump clap from 3.2.14 to 3.2.15 in /src/rust/engine ([pantsbuild#16309](pantsbuild#16309))

* Bump crossbeam-channel from 0.5.5 to 0.5.6 in /src/rust/engine ([pantsbuild#16308](pantsbuild#16308))

* remove spurious quote mark ([pantsbuild#16361](pantsbuild#16361))

* A script to generate known versions data for the terraform binary ([pantsbuild#15958](pantsbuild#15958))

* Add more otel packages to default module mapping + fix to always use tuples ([pantsbuild#16345](pantsbuild#16345))

* [internal] upgrade `async-trait` crate ([pantsbuild#16347](pantsbuild#16347))

* Log dirtied nodes while backtracking. ([pantsbuild#16342](pantsbuild#16342))

* Added Opentelemetry to default Python module mapping ([pantsbuild#16337](pantsbuild#16337))

* Upgrade Toolchain Pants Plugin to 0.21.0 ([pantsbuild#16324](pantsbuild#16324))

* Bump bytes from 1.1.0 to 1.2.0 in /src/rust/engine ([pantsbuild#16245](pantsbuild#16245))

* Bump nix from 0.24.1 to 0.24.2 in /src/rust/engine ([pantsbuild#16307](pantsbuild#16307))

* Fix macos-10.15 brownout. ([pantsbuild#16317](pantsbuild#16317))

* Bump hyper from 0.14.19 to 0.14.20 in /src/rust/engine ([pantsbuild#16164](pantsbuild#16164))

* Bump clap from 3.2.8 to 3.2.14 in /src/rust/engine ([pantsbuild#16269](pantsbuild#16269))

* Don't break builds when pants.log upload fails ([pantsbuild#16294](pantsbuild#16294))

* [internal] Shell completion support ([pantsbuild#16200](pantsbuild#16200))

* Add debug output to help to differentiate retry cases ([pantsbuild#16277](pantsbuild#16277))
illicitonion added a commit to illicitonion/pants that referenced this pull request Aug 6, 2022
@illicitonion
Prep for 2.14.0.dev4
78d745c 
Internal changes:

* [internal] Replace `pkgutil.get_data` with new `read_resource` API ([pantsbuild#16379](pantsbuild#16379))

* Bump bytes from 1.2.0 to 1.2.1 in /src/rust/engine ([pantsbuild#16389](pantsbuild#16389))

* Bump arc-swap from 1.5.0 to 1.5.1 in /src/rust/engine ([pantsbuild#16390](pantsbuild#16390))

* Bump console from 0.15.0 to 0.15.1 in /src/rust/engine ([pantsbuild#16392](pantsbuild#16392))

* Fix incorrect alpha sorting of a maintainer name ([pantsbuild#16401](pantsbuild#16401))

* Add Borja Lorente to Maintainers Emeritus ([pantsbuild#16382](pantsbuild#16382))

* Clarify limited logo usage rights granted by orgs ([pantsbuild#16384](pantsbuild#16384))

* Move Nora Howard to Maintainers Emeritus ([pantsbuild#16383](pantsbuild#16383))

* Include Chris Livingston in Maintainers Emeritus ([pantsbuild#16374](pantsbuild#16374))

* Bump clap from 3.2.14 to 3.2.15 in /src/rust/engine ([pantsbuild#16309](pantsbuild#16309))

* Bump crossbeam-channel from 0.5.5 to 0.5.6 in /src/rust/engine ([pantsbuild#16308](pantsbuild#16308))

* remove spurious quote mark ([pantsbuild#16361](pantsbuild#16361))

* A script to generate known versions data for the terraform binary ([pantsbuild#15958](pantsbuild#15958))

* Add more otel packages to default module mapping + fix to always use tuples ([pantsbuild#16345](pantsbuild#16345))

* [internal] upgrade `async-trait` crate ([pantsbuild#16347](pantsbuild#16347))

* Log dirtied nodes while backtracking. ([pantsbuild#16342](pantsbuild#16342))

* Added Opentelemetry to default Python module mapping ([pantsbuild#16337](pantsbuild#16337))

* Upgrade Toolchain Pants Plugin to 0.21.0 ([pantsbuild#16324](pantsbuild#16324))

* Bump bytes from 1.1.0 to 1.2.0 in /src/rust/engine ([pantsbuild#16245](pantsbuild#16245))

* Bump nix from 0.24.1 to 0.24.2 in /src/rust/engine ([pantsbuild#16307](pantsbuild#16307))

* Fix macos-10.15 brownout. ([pantsbuild#16317](pantsbuild#16317))

* Bump hyper from 0.14.19 to 0.14.20 in /src/rust/engine ([pantsbuild#16164](pantsbuild#16164))

* Bump clap from 3.2.8 to 3.2.14 in /src/rust/engine ([pantsbuild#16269](pantsbuild#16269))

* Don't break builds when pants.log upload fails ([pantsbuild#16294](pantsbuild#16294))

* [internal] Shell completion support ([pantsbuild#16200](pantsbuild#16200))

* Add debug output to help to differentiate retry cases ([pantsbuild#16277](pantsbuild#16277))

* Fix process_executor ([pantsbuild#16428](pantsbuild#16428))
illicitonion added a commit that referenced this pull request Aug 6, 2022
@illicitonion
Prep for 2.14.0.dev4 (#16427)
165bb82 
Internal changes:

* [internal] Replace `pkgutil.get_data` with new `read_resource` API ([#16379](#16379))

* Bump bytes from 1.2.0 to 1.2.1 in /src/rust/engine ([#16389](#16389))

* Bump arc-swap from 1.5.0 to 1.5.1 in /src/rust/engine ([#16390](#16390))

* Bump console from 0.15.0 to 0.15.1 in /src/rust/engine ([#16392](#16392))

* Fix incorrect alpha sorting of a maintainer name ([#16401](#16401))

* Add Borja Lorente to Maintainers Emeritus ([#16382](#16382))

* Clarify limited logo usage rights granted by orgs ([#16384](#16384))

* Move Nora Howard to Maintainers Emeritus ([#16383](#16383))

* Include Chris Livingston in Maintainers Emeritus ([#16374](#16374))

* Bump clap from 3.2.14 to 3.2.15 in /src/rust/engine ([#16309](#16309))

* Bump crossbeam-channel from 0.5.5 to 0.5.6 in /src/rust/engine ([#16308](#16308))

* remove spurious quote mark ([#16361](#16361))

* A script to generate known versions data for the terraform binary ([#15958](#15958))

* Add more otel packages to default module mapping + fix to always use tuples ([#16345](#16345))

* [internal] upgrade `async-trait` crate ([#16347](#16347))

* Log dirtied nodes while backtracking. ([#16342](#16342))

* Added Opentelemetry to default Python module mapping ([#16337](#16337))

* Upgrade Toolchain Pants Plugin to 0.21.0 ([#16324](#16324))

* Bump bytes from 1.1.0 to 1.2.0 in /src/rust/engine ([#16245](#16245))

* Bump nix from 0.24.1 to 0.24.2 in /src/rust/engine ([#16307](#16307))

* Fix macos-10.15 brownout. ([#16317](#16317))

* Bump hyper from 0.14.19 to 0.14.20 in /src/rust/engine ([#16164](#16164))

* Bump clap from 3.2.8 to 3.2.14 in /src/rust/engine ([#16269](#16269))

* Don't break builds when pants.log upload fails ([#16294](#16294))

* [internal] Shell completion support ([#16200](#16200))

* Add debug output to help to differentiate retry cases ([#16277](#16277))

* Fix process_executor ([#16428](#16428))
cczona pushed a commit to cczona/pants that referenced this pull request Sep 1, 2022
@illicitonion @cczona
Prep for 2.14.0.dev4 (pantsbuild#16427)
8cd5389 
Internal changes:

* [internal] Replace `pkgutil.get_data` with new `read_resource` API ([pantsbuild#16379](pantsbuild#16379))

* Bump bytes from 1.2.0 to 1.2.1 in /src/rust/engine ([pantsbuild#16389](pantsbuild#16389))

* Bump arc-swap from 1.5.0 to 1.5.1 in /src/rust/engine ([pantsbuild#16390](pantsbuild#16390))

* Bump console from 0.15.0 to 0.15.1 in /src/rust/engine ([pantsbuild#16392](pantsbuild#16392))

* Fix incorrect alpha sorting of a maintainer name ([pantsbuild#16401](pantsbuild#16401))

* Add Borja Lorente to Maintainers Emeritus ([pantsbuild#16382](pantsbuild#16382))

* Clarify limited logo usage rights granted by orgs ([pantsbuild#16384](pantsbuild#16384))

* Move Nora Howard to Maintainers Emeritus ([pantsbuild#16383](pantsbuild#16383))

* Include Chris Livingston in Maintainers Emeritus ([pantsbuild#16374](pantsbuild#16374))

* Bump clap from 3.2.14 to 3.2.15 in /src/rust/engine ([pantsbuild#16309](pantsbuild#16309))

* Bump crossbeam-channel from 0.5.5 to 0.5.6 in /src/rust/engine ([pantsbuild#16308](pantsbuild#16308))

* remove spurious quote mark ([pantsbuild#16361](pantsbuild#16361))

* A script to generate known versions data for the terraform binary ([pantsbuild#15958](pantsbuild#15958))

* Add more otel packages to default module mapping + fix to always use tuples ([pantsbuild#16345](pantsbuild#16345))

* [internal] upgrade `async-trait` crate ([pantsbuild#16347](pantsbuild#16347))

* Log dirtied nodes while backtracking. ([pantsbuild#16342](pantsbuild#16342))

* Added Opentelemetry to default Python module mapping ([pantsbuild#16337](pantsbuild#16337))

* Upgrade Toolchain Pants Plugin to 0.21.0 ([pantsbuild#16324](pantsbuild#16324))

* Bump bytes from 1.1.0 to 1.2.0 in /src/rust/engine ([pantsbuild#16245](pantsbuild#16245))

* Bump nix from 0.24.1 to 0.24.2 in /src/rust/engine ([pantsbuild#16307](pantsbuild#16307))

* Fix macos-10.15 brownout. ([pantsbuild#16317](pantsbuild#16317))

* Bump hyper from 0.14.19 to 0.14.20 in /src/rust/engine ([pantsbuild#16164](pantsbuild#16164))

* Bump clap from 3.2.8 to 3.2.14 in /src/rust/engine ([pantsbuild#16269](pantsbuild#16269))

* Don't break builds when pants.log upload fails ([pantsbuild#16294](pantsbuild#16294))

* [internal] Shell completion support ([pantsbuild#16200](pantsbuild#16200))

* Add debug output to help to differentiate retry cases ([pantsbuild#16277](pantsbuild#16277))

* Fix process_executor ([pantsbuild#16428](pantsbuild#16428))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsirois jsirois jsirois approved these changes

@tdyas tdyas Awaiting requested review from tdyas

@illicitonion illicitonion Awaiting requested review from illicitonion

Assignees
No one assigned
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stuhood @jsirois