Add more otel packages to default module mapping + fix to always use tuples #16345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tuples also added test to prevent mistakes like the ones I made in pantsbuild#16330
Eric-Arellano
approved these changes
Jul 28, 2022
auto-merge was automatically disabled
July 28, 2022 21:11
Head branch was pushed to by a user without write access
illicitonion
added a commit
to illicitonion/pants
that referenced
this pull request
Aug 5, 2022
Internal changes: * [internal] Replace `pkgutil.get_data` with new `read_resource` API ([pantsbuild#16379](pantsbuild#16379)) * Bump bytes from 1.2.0 to 1.2.1 in /src/rust/engine ([pantsbuild#16389](pantsbuild#16389)) * Bump arc-swap from 1.5.0 to 1.5.1 in /src/rust/engine ([pantsbuild#16390](pantsbuild#16390)) * Bump console from 0.15.0 to 0.15.1 in /src/rust/engine ([pantsbuild#16392](pantsbuild#16392)) * Fix incorrect alpha sorting of a maintainer name ([pantsbuild#16401](pantsbuild#16401)) * Add Borja Lorente to Maintainers Emeritus ([pantsbuild#16382](pantsbuild#16382)) * Clarify limited logo usage rights granted by orgs ([pantsbuild#16384](pantsbuild#16384)) * Move Nora Howard to Maintainers Emeritus ([pantsbuild#16383](pantsbuild#16383)) * Include Chris Livingston in Maintainers Emeritus ([pantsbuild#16374](pantsbuild#16374)) * Bump clap from 3.2.14 to 3.2.15 in /src/rust/engine ([pantsbuild#16309](pantsbuild#16309)) * Bump crossbeam-channel from 0.5.5 to 0.5.6 in /src/rust/engine ([pantsbuild#16308](pantsbuild#16308)) * remove spurious quote mark ([pantsbuild#16361](pantsbuild#16361)) * A script to generate known versions data for the terraform binary ([pantsbuild#15958](pantsbuild#15958)) * Add more otel packages to default module mapping + fix to always use tuples ([pantsbuild#16345](pantsbuild#16345)) * [internal] upgrade `async-trait` crate ([pantsbuild#16347](pantsbuild#16347)) * Log dirtied nodes while backtracking. ([pantsbuild#16342](pantsbuild#16342)) * Added Opentelemetry to default Python module mapping ([pantsbuild#16337](pantsbuild#16337)) * Upgrade Toolchain Pants Plugin to 0.21.0 ([pantsbuild#16324](pantsbuild#16324)) * Bump bytes from 1.1.0 to 1.2.0 in /src/rust/engine ([pantsbuild#16245](pantsbuild#16245)) * Bump nix from 0.24.1 to 0.24.2 in /src/rust/engine ([pantsbuild#16307](pantsbuild#16307)) * Fix macos-10.15 brownout. ([pantsbuild#16317](pantsbuild#16317)) * Bump hyper from 0.14.19 to 0.14.20 in /src/rust/engine ([pantsbuild#16164](pantsbuild#16164)) * Bump clap from 3.2.8 to 3.2.14 in /src/rust/engine ([pantsbuild#16269](pantsbuild#16269)) * Don't break builds when pants.log upload fails ([pantsbuild#16294](pantsbuild#16294)) * [internal] Shell completion support ([pantsbuild#16200](pantsbuild#16200)) * Add debug output to help to differentiate retry cases ([pantsbuild#16277](pantsbuild#16277))
Merged
illicitonion
added a commit
to illicitonion/pants
that referenced
this pull request
Aug 5, 2022
Internal changes: * [internal] Replace `pkgutil.get_data` with new `read_resource` API ([pantsbuild#16379](pantsbuild#16379)) * Bump bytes from 1.2.0 to 1.2.1 in /src/rust/engine ([pantsbuild#16389](pantsbuild#16389)) * Bump arc-swap from 1.5.0 to 1.5.1 in /src/rust/engine ([pantsbuild#16390](pantsbuild#16390)) * Bump console from 0.15.0 to 0.15.1 in /src/rust/engine ([pantsbuild#16392](pantsbuild#16392)) * Fix incorrect alpha sorting of a maintainer name ([pantsbuild#16401](pantsbuild#16401)) * Add Borja Lorente to Maintainers Emeritus ([pantsbuild#16382](pantsbuild#16382)) * Clarify limited logo usage rights granted by orgs ([pantsbuild#16384](pantsbuild#16384)) * Move Nora Howard to Maintainers Emeritus ([pantsbuild#16383](pantsbuild#16383)) * Include Chris Livingston in Maintainers Emeritus ([pantsbuild#16374](pantsbuild#16374)) * Bump clap from 3.2.14 to 3.2.15 in /src/rust/engine ([pantsbuild#16309](pantsbuild#16309)) * Bump crossbeam-channel from 0.5.5 to 0.5.6 in /src/rust/engine ([pantsbuild#16308](pantsbuild#16308)) * remove spurious quote mark ([pantsbuild#16361](pantsbuild#16361)) * A script to generate known versions data for the terraform binary ([pantsbuild#15958](pantsbuild#15958)) * Add more otel packages to default module mapping + fix to always use tuples ([pantsbuild#16345](pantsbuild#16345)) * [internal] upgrade `async-trait` crate ([pantsbuild#16347](pantsbuild#16347)) * Log dirtied nodes while backtracking. ([pantsbuild#16342](pantsbuild#16342)) * Added Opentelemetry to default Python module mapping ([pantsbuild#16337](pantsbuild#16337)) * Upgrade Toolchain Pants Plugin to 0.21.0 ([pantsbuild#16324](pantsbuild#16324)) * Bump bytes from 1.1.0 to 1.2.0 in /src/rust/engine ([pantsbuild#16245](pantsbuild#16245)) * Bump nix from 0.24.1 to 0.24.2 in /src/rust/engine ([pantsbuild#16307](pantsbuild#16307)) * Fix macos-10.15 brownout. ([pantsbuild#16317](pantsbuild#16317)) * Bump hyper from 0.14.19 to 0.14.20 in /src/rust/engine ([pantsbuild#16164](pantsbuild#16164)) * Bump clap from 3.2.8 to 3.2.14 in /src/rust/engine ([pantsbuild#16269](pantsbuild#16269)) * Don't break builds when pants.log upload fails ([pantsbuild#16294](pantsbuild#16294)) * [internal] Shell completion support ([pantsbuild#16200](pantsbuild#16200)) * Add debug output to help to differentiate retry cases ([pantsbuild#16277](pantsbuild#16277))
illicitonion
added a commit
to illicitonion/pants
that referenced
this pull request
Aug 6, 2022
Internal changes: * [internal] Replace `pkgutil.get_data` with new `read_resource` API ([pantsbuild#16379](pantsbuild#16379)) * Bump bytes from 1.2.0 to 1.2.1 in /src/rust/engine ([pantsbuild#16389](pantsbuild#16389)) * Bump arc-swap from 1.5.0 to 1.5.1 in /src/rust/engine ([pantsbuild#16390](pantsbuild#16390)) * Bump console from 0.15.0 to 0.15.1 in /src/rust/engine ([pantsbuild#16392](pantsbuild#16392)) * Fix incorrect alpha sorting of a maintainer name ([pantsbuild#16401](pantsbuild#16401)) * Add Borja Lorente to Maintainers Emeritus ([pantsbuild#16382](pantsbuild#16382)) * Clarify limited logo usage rights granted by orgs ([pantsbuild#16384](pantsbuild#16384)) * Move Nora Howard to Maintainers Emeritus ([pantsbuild#16383](pantsbuild#16383)) * Include Chris Livingston in Maintainers Emeritus ([pantsbuild#16374](pantsbuild#16374)) * Bump clap from 3.2.14 to 3.2.15 in /src/rust/engine ([pantsbuild#16309](pantsbuild#16309)) * Bump crossbeam-channel from 0.5.5 to 0.5.6 in /src/rust/engine ([pantsbuild#16308](pantsbuild#16308)) * remove spurious quote mark ([pantsbuild#16361](pantsbuild#16361)) * A script to generate known versions data for the terraform binary ([pantsbuild#15958](pantsbuild#15958)) * Add more otel packages to default module mapping + fix to always use tuples ([pantsbuild#16345](pantsbuild#16345)) * [internal] upgrade `async-trait` crate ([pantsbuild#16347](pantsbuild#16347)) * Log dirtied nodes while backtracking. ([pantsbuild#16342](pantsbuild#16342)) * Added Opentelemetry to default Python module mapping ([pantsbuild#16337](pantsbuild#16337)) * Upgrade Toolchain Pants Plugin to 0.21.0 ([pantsbuild#16324](pantsbuild#16324)) * Bump bytes from 1.1.0 to 1.2.0 in /src/rust/engine ([pantsbuild#16245](pantsbuild#16245)) * Bump nix from 0.24.1 to 0.24.2 in /src/rust/engine ([pantsbuild#16307](pantsbuild#16307)) * Fix macos-10.15 brownout. ([pantsbuild#16317](pantsbuild#16317)) * Bump hyper from 0.14.19 to 0.14.20 in /src/rust/engine ([pantsbuild#16164](pantsbuild#16164)) * Bump clap from 3.2.8 to 3.2.14 in /src/rust/engine ([pantsbuild#16269](pantsbuild#16269)) * Don't break builds when pants.log upload fails ([pantsbuild#16294](pantsbuild#16294)) * [internal] Shell completion support ([pantsbuild#16200](pantsbuild#16200)) * Add debug output to help to differentiate retry cases ([pantsbuild#16277](pantsbuild#16277)) * Fix process_executor ([pantsbuild#16428](pantsbuild#16428))
illicitonion
added a commit
that referenced
this pull request
Aug 6, 2022
Internal changes: * [internal] Replace `pkgutil.get_data` with new `read_resource` API ([#16379](#16379)) * Bump bytes from 1.2.0 to 1.2.1 in /src/rust/engine ([#16389](#16389)) * Bump arc-swap from 1.5.0 to 1.5.1 in /src/rust/engine ([#16390](#16390)) * Bump console from 0.15.0 to 0.15.1 in /src/rust/engine ([#16392](#16392)) * Fix incorrect alpha sorting of a maintainer name ([#16401](#16401)) * Add Borja Lorente to Maintainers Emeritus ([#16382](#16382)) * Clarify limited logo usage rights granted by orgs ([#16384](#16384)) * Move Nora Howard to Maintainers Emeritus ([#16383](#16383)) * Include Chris Livingston in Maintainers Emeritus ([#16374](#16374)) * Bump clap from 3.2.14 to 3.2.15 in /src/rust/engine ([#16309](#16309)) * Bump crossbeam-channel from 0.5.5 to 0.5.6 in /src/rust/engine ([#16308](#16308)) * remove spurious quote mark ([#16361](#16361)) * A script to generate known versions data for the terraform binary ([#15958](#15958)) * Add more otel packages to default module mapping + fix to always use tuples ([#16345](#16345)) * [internal] upgrade `async-trait` crate ([#16347](#16347)) * Log dirtied nodes while backtracking. ([#16342](#16342)) * Added Opentelemetry to default Python module mapping ([#16337](#16337)) * Upgrade Toolchain Pants Plugin to 0.21.0 ([#16324](#16324)) * Bump bytes from 1.1.0 to 1.2.0 in /src/rust/engine ([#16245](#16245)) * Bump nix from 0.24.1 to 0.24.2 in /src/rust/engine ([#16307](#16307)) * Fix macos-10.15 brownout. ([#16317](#16317)) * Bump hyper from 0.14.19 to 0.14.20 in /src/rust/engine ([#16164](#16164)) * Bump clap from 3.2.8 to 3.2.14 in /src/rust/engine ([#16269](#16269)) * Don't break builds when pants.log upload fails ([#16294](#16294)) * [internal] Shell completion support ([#16200](#16200)) * Add debug output to help to differentiate retry cases ([#16277](#16277)) * Fix process_executor ([#16428](#16428))
cczona
pushed a commit
to cczona/pants
that referenced
this pull request
Sep 1, 2022
…tuples (pantsbuild#16345) As a follow up for pantsbuild#16337 also added test to prevent mistakes like the ones I made in pantsbuild#16330 [ci skip-rust] [ci skip-build-wheels]
cczona
pushed a commit
to cczona/pants
that referenced
this pull request
Sep 1, 2022
Internal changes: * [internal] Replace `pkgutil.get_data` with new `read_resource` API ([pantsbuild#16379](pantsbuild#16379)) * Bump bytes from 1.2.0 to 1.2.1 in /src/rust/engine ([pantsbuild#16389](pantsbuild#16389)) * Bump arc-swap from 1.5.0 to 1.5.1 in /src/rust/engine ([pantsbuild#16390](pantsbuild#16390)) * Bump console from 0.15.0 to 0.15.1 in /src/rust/engine ([pantsbuild#16392](pantsbuild#16392)) * Fix incorrect alpha sorting of a maintainer name ([pantsbuild#16401](pantsbuild#16401)) * Add Borja Lorente to Maintainers Emeritus ([pantsbuild#16382](pantsbuild#16382)) * Clarify limited logo usage rights granted by orgs ([pantsbuild#16384](pantsbuild#16384)) * Move Nora Howard to Maintainers Emeritus ([pantsbuild#16383](pantsbuild#16383)) * Include Chris Livingston in Maintainers Emeritus ([pantsbuild#16374](pantsbuild#16374)) * Bump clap from 3.2.14 to 3.2.15 in /src/rust/engine ([pantsbuild#16309](pantsbuild#16309)) * Bump crossbeam-channel from 0.5.5 to 0.5.6 in /src/rust/engine ([pantsbuild#16308](pantsbuild#16308)) * remove spurious quote mark ([pantsbuild#16361](pantsbuild#16361)) * A script to generate known versions data for the terraform binary ([pantsbuild#15958](pantsbuild#15958)) * Add more otel packages to default module mapping + fix to always use tuples ([pantsbuild#16345](pantsbuild#16345)) * [internal] upgrade `async-trait` crate ([pantsbuild#16347](pantsbuild#16347)) * Log dirtied nodes while backtracking. ([pantsbuild#16342](pantsbuild#16342)) * Added Opentelemetry to default Python module mapping ([pantsbuild#16337](pantsbuild#16337)) * Upgrade Toolchain Pants Plugin to 0.21.0 ([pantsbuild#16324](pantsbuild#16324)) * Bump bytes from 1.1.0 to 1.2.0 in /src/rust/engine ([pantsbuild#16245](pantsbuild#16245)) * Bump nix from 0.24.1 to 0.24.2 in /src/rust/engine ([pantsbuild#16307](pantsbuild#16307)) * Fix macos-10.15 brownout. ([pantsbuild#16317](pantsbuild#16317)) * Bump hyper from 0.14.19 to 0.14.20 in /src/rust/engine ([pantsbuild#16164](pantsbuild#16164)) * Bump clap from 3.2.8 to 3.2.14 in /src/rust/engine ([pantsbuild#16269](pantsbuild#16269)) * Don't break builds when pants.log upload fails ([pantsbuild#16294](pantsbuild#16294)) * [internal] Shell completion support ([pantsbuild#16200](pantsbuild#16200)) * Add debug output to help to differentiate retry cases ([pantsbuild#16277](pantsbuild#16277)) * Fix process_executor ([pantsbuild#16428](pantsbuild#16428))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up for #16337
also added test to prevent mistakes like the ones I made in #16330