-
-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add shutdown
method to CommandRunner
#16930
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
[ci skip-build-wheels]
Co-authored-by: Stu Hood <stuhood@gmail.com> # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
[ci skip-rust] [ci skip-build-wheels]
[ci skip-build-wheels]
[ci skip-build-wheels]
8838a95
to
42e3141
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@tdyas : For posterity, here is an example of the hang that was located via #16927: https://gist.github.com/stuhood/d05d4fcc2b2fd7e464fa397c362eb894 Looking at it again, the thing that jumps out at me is that the thing that is being So... it's possible that this is because |
Oh. Is it possible that we're failing to connect to That could probably also skip tearing anything down if the |
I'll put that fix in now as a separate PR since this one already landed. |
The Docker command runner needs to cleanly remove cached containers when it shuts down. The removal API must be called in an async context, however, so the shutdown cannot be performed from drop handler since that is a non-async context.
Add a
shutdown
method toCommandRunner
and implement it for all relevant command runners. For the Docker command runner, this means that the shutdown logic forContainerCache
will be invoked in an async context.[ci skip-build-wheels]