Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add shutdown method to CommandRunner #16930

Merged
merged 5 commits into from
Sep 21, 2022
Merged

add shutdown method to CommandRunner #16930

merged 5 commits into from
Sep 21, 2022

Commits on Sep 21, 2022

  1. add shutdown method to CommandRunner 

    [ci skip-build-wheels]
    Tom Dyas committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    739a93b View commit details
    Browse the repository at this point in the history

  2. Update src/rust/engine/process_execution/src/lib.rs 

    Co-authored-by: Stu Hood <stuhood@gmail.com>
# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
    @tdyas
    tdyas authored and Tom Dyas committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    f383e0e View commit details
    Browse the repository at this point in the history

  3. remove shutdown call added where it was not needed 

    [ci skip-rust]

[ci skip-build-wheels]
    Tom Dyas committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    6bc0de9 View commit details
    Browse the repository at this point in the history

  4. require explicit impl of shutdown method 

    [ci skip-build-wheels]
    Tom Dyas committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    57b201c View commit details
    Browse the repository at this point in the history

  5. always shutdown command runner in test 

    [ci skip-build-wheels]
    Tom Dyas committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    42e3141 View commit details
    Browse the repository at this point in the history