Always have coloured output and then strip later for pytest, helm unittest, shunit2 #19923
+173
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to increase cache hit rates by having Pytest, Helm unittest and shUnit2 have more consistent command line args/env vars, that don't depend on the value of
[GLOBAL].color(or othercolorsetting): in particular, these processes will now always output with colours under the hood, and Pants post-processes the output based on the flag.The hope is that this allows more cache hits, particularly remote, where someone might be running locally with colours but a remote tester runs without.
This does a bunch of refactoring to pull out the adhoc colour stripping applied in
CheckResultetc, and make it more reusable. This will breaks plugins that set the args (maybe we should deprecate them rather than just straight remove?).Fixes #16526