-
-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerate all Python tool lock-files (updating many) and update to pip_version = 24.0, for Py 3.12 support #20365
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
In that it pulls in more updates than are strictly needed just for 3.12 compatibility? |
Yeah, exactly. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
d5e93ce
to
b284fd1
Compare
ba0cf3a
to
fe472e9
Compare
fe472e9
to
cf2fe18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you ❤️
I just noticed this because I was changing some settings and accidentally used the pants-provided lockfile instead of my own.
|
@purajit are you in a position to submit a fix along those lines? Thanks |
On it! Just wanted to be sure there wasn't an explicit reason to go to 4.3.2 besides just being newer. I also see there was a new version a couple weeks ago - going to check that out. |
Made a PR ^ |
…arsing issues (#21361) `python-hcl2` 4.3.1+ has some serious issues with parsing certain kinds of expressions, like multi-line ternaries. The issues opened can be seen [here](https://github.com/amplify-education/python-hcl2/issues?q=is%3Aissue+is%3Aopen+%22unexpected+token%22). It looks like 4.3.5 has fixed a bunch of the issues, but I'm still seeing some errors on our repo, and I think it's better to keep to 4.3.0 until the authors of the issues close them and we're sure there are no regressions. Also, 4.3.0 is still compatible with py3.12, so it doesn't undo the efforts of #20365. Generated with `pants run build-support/bin/generate_builtin_lockfiles.py -- terraform-hcl2-parser`.
…arsing issues (#21361) `python-hcl2` 4.3.1+ has some serious issues with parsing certain kinds of expressions, like multi-line ternaries. The issues opened can be seen [here](https://github.com/amplify-education/python-hcl2/issues?q=is%3Aissue+is%3Aopen+%22unexpected+token%22). It looks like 4.3.5 has fixed a bunch of the issues, but I'm still seeing some errors on our repo, and I think it's better to keep to 4.3.0 until the authors of the issues close them and we're sure there are no regressions. Also, 4.3.0 is still compatible with py3.12, so it doesn't undo the efforts of #20365. Generated with `pants run build-support/bin/generate_builtin_lockfiles.py -- terraform-hcl2-parser`.
…arsing issues (#21361) `python-hcl2` 4.3.1+ has some serious issues with parsing certain kinds of expressions, like multi-line ternaries. The issues opened can be seen [here](https://github.com/amplify-education/python-hcl2/issues?q=is%3Aissue+is%3Aopen+%22unexpected+token%22). It looks like 4.3.5 has fixed a bunch of the issues, but I'm still seeing some errors on our repo, and I think it's better to keep to 4.3.0 until the authors of the issues close them and we're sure there are no regressions. Also, 4.3.0 is still compatible with py3.12, so it doesn't undo the efforts of #20365. Generated with `pants run build-support/bin/generate_builtin_lockfiles.py -- terraform-hcl2-parser`.
…arsing issues (Cherry-pick of #21361) (#21364) `python-hcl2` 4.3.1+ has some serious issues with parsing certain kinds of expressions, like multi-line ternaries. The issues opened can be seen [here](https://github.com/amplify-education/python-hcl2/issues?q=is%3Aissue+is%3Aopen+%22unexpected+token%22). It looks like 4.3.5 has fixed a bunch of the issues, but I'm still seeing some errors on our repo, and I think it's better to keep to 4.3.0 until the authors of the issues close them and we're sure there are no regressions. Also, 4.3.0 is still compatible with py3.12, so it doesn't undo the efforts of #20365. Generated with `pants run build-support/bin/generate_builtin_lockfiles.py -- terraform-hcl2-parser`. Co-authored-by: purajit <purajit.malalur@color.com>
…arsing issues (Cherry-pick of #21361) (#21365) `python-hcl2` 4.3.1+ has some serious issues with parsing certain kinds of expressions, like multi-line ternaries. The issues opened can be seen [here](https://github.com/amplify-education/python-hcl2/issues?q=is%3Aissue+is%3Aopen+%22unexpected+token%22). It looks like 4.3.5 has fixed a bunch of the issues, but I'm still seeing some errors on our repo, and I think it's better to keep to 4.3.0 until the authors of the issues close them and we're sure there are no regressions. Also, 4.3.0 is still compatible with py3.12, so it doesn't undo the efforts of #20365. Generated with `pants run build-support/bin/generate_builtin_lockfiles.py -- terraform-hcl2-parser`. Co-authored-by: purajit <purajit.malalur@color.com>
This does three things to fix #20354 and give Pants Python 3.12 support by default:
[python].pip_version
value to24.0
(from23.1.2
), which is the current latest and is after 23.2, which is the first that supports Python 3.12pants run build-support/bin/generate_builtin_lockfiles.py -- --all-python
to update all tool lockfiles... this involves updating many tools, as a Big Bang, which is potentially unhelpful.docformatter
has to be restricted to the current version 1.4: 1.5.1 (the newest version that satisfies the old constraints) crashes on Pants itself (IndexError: list index out of range on pre-commit PyCQA/docformatter#151), while 1.7.5 (the newest version) also doesn't work on Pants (Update builtin docformatter to 1.7.5 #20498)Here's a list of (as best I can tell), the changes in versions for the "main" requirement for each subsystem:
helm-k8s-parser
hikaru
helm-post-renderer
yamlpath
autoflake
autoflake
bandit
bandit
black
black
pyupgrade
pyupgrade
ruff
ruff
yapf
yapf
coverage-py
coverage
debugpy
debugpy
mypy
mypy
terraform-hcl2-parser
python-hcl2
yamllint
yamllint
There's numerous other transitive dependencies updated too, including in subsystems for which the main requirement hasn't changed and aren't listed above.
I haven't checked changelogs for any of these.
I've confirmed that running the reproducer from #20354 with this code now works. The commits are 'sensible'.