Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add workaround for release publishing action mishandling `draft: true…
…` -> `false` transition (#444) This works around `softprops/action-gh-release` not being able to properly "publish" a release by changing `draft: true` to `draft: false`. The intention is that the step with `draft: false` would find the existing draft release and update it (publishing it). This is what correctly happened for a testing `v0.12.3-beta.3` release from this branch: https://github.com/pantsbuild/scie-pants/releases/tag/v0.12.3-beta.3 (I also did attempted a `v0.12.3-beta.2` from this branch, but that used a newer version of the action code and failed completely, see below.) Previously, the action would fail to find the existing draft release and instead create a duplicate one. The old behaviour is visible (to people who can see draft releases) with `v0.12.3-beta.0` and `-beta.1`. The particular new version of the action is: - changes: softprops/action-gh-release@master...huonw:action-gh-release:huonw/pantsbuild-fix-see-scie-pants-439 (specifically commit huonw/action-gh-release@998f80d from branch https://github.com/huonw/action-gh-release/commits/huonw/pantsbuild-fix-see-scie-pants-439 ) - this is v2.0.9 (the current `v2` tag) with softprops/action-gh-release#316 merged in - using v2.2.0 (the latest version of the action) fails while uploading artifacts with errors like `Request body length does not match content-length header`, so this sticks with the older version.
- Loading branch information