Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for release publishing action mishandling draft: true -> false transition #444

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

huonw
Copy link
Contributor

@huonw huonw commented Dec 11, 2024

This works around softprops/action-gh-release not being able to properly "publish" a release by changing draft: true to draft: false.

The intention is that the step with draft: false would find the existing draft release and update it (publishing it). This is what correctly happened for a testing v0.12.3-beta.3 release from this branch: https://github.com/pantsbuild/scie-pants/releases/tag/v0.12.3-beta.3 (I also did attempted a v0.12.3-beta.2 from this branch, but that used a newer version of the action code and failed completely, see below.)

Previously, the action would fail to find the existing draft release and instead create a duplicate one. The old behaviour is visible (to people who can see draft releases) with v0.12.3-beta.0 and -beta.1:

image

The particular new version of the action is:

@huonw huonw marked this pull request as ready for review December 11, 2024 05:48
@huonw huonw changed the title Add workaround for action mishandling of draft: true -> false transition Add workaround for release publishing action mishandling draft: true -> false transition Dec 11, 2024
@huonw huonw requested a review from benjyw December 11, 2024 05:49
Copy link
Contributor

@benjyw benjyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully that PR gets upstreamed soon... Can we prompt them about it?

@huonw huonw merged commit 9d73b15 into main Dec 12, 2024
14 checks passed
@huonw
Copy link
Contributor Author

huonw commented Dec 12, 2024

I've left a comment because it seemed like seeing real world usage was part of the review process, good call-out.

@huonw huonw deleted the huonw/release-fix-again branch December 12, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants