Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual artifacts when opening windows with mutter 3.36.4 #328

Closed
shibotto opened this issue Jul 11, 2020 · 5 comments · Fixed by #501
Closed

Visual artifacts when opening windows with mutter 3.36.4 #328

shibotto opened this issue Jul 11, 2020 · 5 comments · Fixed by #501
Assignees
@jtaala

Comments

@shibotto
Copy link

3.36.3 (good)
3-36-3

3.36.4 (bad, notice the blue rectangles)
3-36-4

I bisected the mutter commit that introduced this down to https://gitlab.gnome.org/GNOME/mutter/-/commit/44a3358125317dbe2151cf0ac70ec2c382236881.

I can only reproduce this using PaperWM, vanilla GNOME doesn't seem to be affected.
@hedning
Copy link
Member

hedning commented Jul 11, 2020

Right, I suspected there might be some breakage when looking at the release notes.

Thanks for taking the time bisecting the problem. Will take a look.

@azmeuk
Copy link

azmeuk commented Oct 13, 2020

With mutter 3.38.1 I have a lot of those too. More generally the whole user experience has been degraded with GNOME 3.38 (glitches, latencies, etc.), but nothing I can reproduce at will.

@shibotto
Copy link
Author

Still a problem (even worse maybe) with GNOME 43 + Xorg and develop branch :(

2022-10-16.00-46-24.mp4

@jtaala jtaala self-assigned this Mar 2, 2023
@jtaala
Copy link
Collaborator

jtaala commented Mar 2, 2023 •
edited
Loading

Thanks @shibotto, your comment re still happening on Gnome 43 caught my attention (I'm also on Gnome 43).

I didn't really notice it (but then again I prefer speeding up animation-time to 0.15). Changing animation-time to 0.99 you can see the selected actor being drawn with the rectangles you refer to for some of the windows.

Will have a look and see about cleaning up / improving the animation/tween used.

@jtaala jtaala mentioned this issue Mar 28, 2023
Merged
@jtaala
Copy link
Collaborator

jtaala commented Mar 28, 2023

Hey @shibotto, sorry it took a while (was working on a few different things).

Anyways, checkout #501 - it should look much better (also I put up some before/after vids in that PR).

jtaala added a commit that referenced this issue Mar 29, 2023
@jtaala
FIX and improve new window create/insert tween (animation) (#501)
1a8c087 
Fixes #328.

This PR fixes and improves the new window create/insert tween. Also
resolves a noticable issue where part of current selected window is
clipped during window creation.

See below for comparison between current tween and new tween:

**Note the transitions have been slowed down for demonstration purposes.
Also, I'm using a styled `selection` (pinkish colour - because I like it
but also to see it better for this demonstration)**

### current transitions (slowed down so can see issues with certain
applications):

https://user-images.githubusercontent.com/30424662/228228961-34250abe-7fb6-4141-a1c7-a55f23b54ec4.mp4

### new (improved) transitions (slowed down to see them better):

https://user-images.githubusercontent.com/30424662/228229082-d0088765-6cd8-499f-8c06-26dfba21952e.mp4

_NOTE: this PR has been implemented in the
[PaperWM-redux](https://github.com/PaperWM-redux/PaperWM) fork, which
you can install if you want this, or any of [my
PRs](https://github.com/paperwm/PaperWM/pulls/jtaala) that are open._
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jtaala jtaala

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX and improve new window create/insert tween (animation) PaperWM-redux/PaperWM
4 participants
@azmeuk @hedning @shibotto @jtaala