FIX and improve new window create/insert tween (animation) #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only. Resolved clipping issue during transition.
|
Does this also fixes #347? |
Lythenas
reviewed
Mar 28, 2023
Not intentionally. I had a quick look at that one and couldn't quite understand from the video what glitch they were referring to (was it the pdf viewer in the video that looked weird?). If so, I haven't experienced that issue (i.e. I can't reproduce). I'll comment on that issue directly. |
Lythenas
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #328.
This PR fixes and improves the new window create/insert tween. Also resolves a noticable issue where part of current selected window is clipped during window creation.
See below for comparison between current tween and new tween:
Note the transitions have been slowed down for demonstration purposes. Also, I'm using a styled
selection(pinkish colour - because I like it but also to see it better for this demonstration)current transitions (slowed down so can see issues with certain applications):
paperwm-newwindow-tween-current.mp4
new (improved) transitions (slowed down to see them better):
paperwm-newwindow-tween-improved.mp4
NOTE: this PR has been implemented in the PaperWM-redux fork, which you can install if you want this, or any of my PRs that are open.