Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Overview transition animation on window selection #672

Closed
mepowerleo10 opened this issue Nov 8, 2023 · 13 comments · Fixed by #715
Closed

Disable Overview transition animation on window selection #672

mepowerleo10 opened this issue Nov 8, 2023 · 13 comments · Fixed by #715
Assignees
Labels
enhancement Adds a new feature or extends scope visual-enhancement Enhancement to improve visual/animations

Comments

@mepowerleo10
Copy link

Is your feature request related to a problem? Please describe.
Sometimes selecting a window from the overview is much faster than navigating using the keyboard. But each time I select a window from the overview when using PaperWM, the overview translation animation runs which gets disorienting after multiple uses.

Describe the solution you'd like
Instead of animating the translation to the window selected from the overview, there can be an option to just fade in the window.

Describe alternatives you've considered

  • Speeding up the animations for the GNOME shell
  • Disabling animations
  • Speeding up animations in PaperWM

Additional context
https://github.com/paperwm/PaperWM/assets/26873863/9778a130-a13d-4d54-b51b-ad9fb07d22f1

@mepowerleo10 mepowerleo10 added the enhancement Adds a new feature or extends scope label Nov 8, 2023
@jtaala
Copy link
Collaborator

jtaala commented Nov 8, 2023

Do you mean the entire overview animation (including gnome overview animation) or just the animation at the end (where PaperWM takes you to the tiled position of the window that was selected)?

Interestingly, if you mean the latter - then that's what used to happen but this issue saw that behaviour as a glitch (or at least more confusing).

@jtaala
Copy link
Collaborator

jtaala commented Nov 8, 2023

Instead of animating the translation to the window selected from the overview, there can be an option to just fade in the window.

This is kind of interesting - we can't really change the gnome overview exit animation, but fading out / in to show the new window position might look kind of cool (or weird).

If anyone is interested in giving this one a go feel free to submit a PR for this.

@mepowerleo10
Copy link
Author

I mean the animation at the end. If you have 10 windows on the same workspace, it just gets even more confusing.

Interestingly, if you mean the latter - then that's what used to happen but this issue saw that behaviour as a glitch (or at least more confusing).

Oh! I missed that issue, but is it possible to have an option to switch this behaviour on/off? Or it interferes with the current implementation?

@jtaala
Copy link
Collaborator

jtaala commented Nov 8, 2023

Well, it's possible - previously it just snapped to the window (see videos from that issue) which was quite disjoint after the gnome overview exit animation zoom in back in... then snapping/jumping to another window (that might be tiled offscreen).

@jtaala
Copy link
Collaborator

jtaala commented Nov 8, 2023

Anyways, making that an option is fairly trivial - but I think the fading might be a pretty cool (less jarring?) option?

@jtaala
Copy link
Collaborator

jtaala commented Nov 8, 2023

@mepowerleo10, what do you reckon? Better or worse? This uses a slight fade-in effect (instead of the translation effect) after overview:

Kooha-2023-11-08-21-07-36.mp4

@mepowerleo10
Copy link
Author

Anyways, making that an option is fairly trivial - but I think the fading might be a pretty cool (less jarring?) option?

The fading effect might be a nice touch

@mepowerleo10
Copy link
Author

@mepowerleo10, what do you reckon? Better or worse? This uses a slight fade-in effect (instead of the translation effect) after overview:

Kooha-2023-11-08-21-07-36.mp4

I think this is much better @jtaala

@jtaala jtaala added the visual-enhancement Enhancement to improve visual/animations label Nov 9, 2023
@jtaala jtaala self-assigned this Nov 9, 2023
@vvvvvvitor
Copy link

@mepowerleo10, what do you reckon? Better or worse? This uses a slight fade-in effect (instead of the translation effect) after overview:

Kooha-2023-11-08-21-07-36.mp4

Much better, but it would be even better if it just used the normal gnome animation like previously.

@jtaala
Copy link
Collaborator

jtaala commented Nov 11, 2023

Much better, but it would be even better if it just used the normal gnome animation like previously.

Indeed would be great, but gnome overview isn't aware of how we tiled windows and how we move the entire scrolling container - so it animates windows to where it was offscreen... hence we can only control what happens after overview exit animation.

If someone wants to give the above a go though (although I think it would require rewriting quite a bit of gnome overview animation/easing code etc.), we would def accept a PR for it.

@jtaala
Copy link
Collaborator

jtaala commented Nov 11, 2023

Actually, we might be able to pre-move the cloneContainer (Clutter container that holds our tiled clones) and have it in place before exit animation starts... (maybe).

I'll play around some more with this after we merge in #679.

@jtaala
Copy link
Collaborator

jtaala commented Nov 26, 2023

Hey all,

I've added options to PaperWM settings now to set the Gnome overview (exit) "select window" animation. See #715.

To test this out:

git clone https://github.com/paperwm/PaperWM.git
cd PaperWM
git checkout enhancement-672-overview-exit-transition-animation
./install.sh

then logout / login.

@jtaala
Copy link
Collaborator

jtaala commented Nov 26, 2023

Actually, we might be able to pre-move the cloneContainer (Clutter container that holds our tiled clones) and have it in place before exit animation starts... (maybe).

I'll play around some more with this after we merge in #679.

Just commenting on this. So, we do use the default Gnome overview - problem with the overview animation is it return to the original window positions... so we still need a "post" Gnome Overview animation to bring the tiled window into view.

You can see this by disabling PaperWM and moving a window right offscreen (to simulate what PaperWM does) and then going into overview and selecting that window:

Kooha-2023-11-26-17-13-03.mp4

@jtaala jtaala closed this as completed in faaf59e Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adds a new feature or extends scope visual-enhancement Enhancement to improve visual/animations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants