Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 526 open new window position gnome45 #679

Merged
merged 5 commits into from
Nov 11, 2023

Conversation

jtaala
Copy link
Collaborator

@jtaala jtaala commented Nov 10, 2023

Completes #526 by adding options to set where to insert new windows (e.g. to the left / right of windows, or at start / end of tiling):

image

@jtaala jtaala linked an issue Nov 10, 2023 that may be closed by this pull request
@jtaala jtaala requested a review from Lythenas November 10, 2023 23:54
@jtaala jtaala added the merging soon Label for PRs that are planned to be merged soon (usually within the next week) label Nov 11, 2023
Copy link
Collaborator

@Lythenas Lythenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this out and it works as expected.

tiling.js Outdated Show resolved Hide resolved
@jtaala
Copy link
Collaborator Author

jtaala commented Nov 11, 2023

@Lythenas what do think about this?

Since super-I also pulls from the right, any change would also need to affect it presumably.

from #526 (comment)

Should we also change the side that we pull windows from (e.g. make it pull windows from the left?). I'm thinking probably should for consistency?

@Lythenas
Copy link
Collaborator

Lythenas commented Nov 11, 2023

Should we also change the side that we pull windows from (e.g. make it pull windows from the left?). I'm thinking probably should for consistency?

Would it then also pull from start or end? Not sure how much sense that makes. But I don't really use columns, so not sure.

@jtaala
Copy link
Collaborator Author

jtaala commented Nov 11, 2023

Would it then also pull from start or end? Not sure how much sense that makes. But I don't really use columns, so not sure.

Yeah, that does seem a bit weird - in the case of start/end I think it would make sense to just pull from left/right respectively.

@Lythenas
Copy link
Collaborator

Then we should maybe just add one new keybinding for it instead of using this setting, since it does not really match up with the 4 options anymore.

@jtaala
Copy link
Collaborator Author

jtaala commented Nov 11, 2023

Then we should maybe just add one new keybinding for it instead of using this setting, since it does not really match up with the 4 options anymore.

Yeah, I agree - that would make more sense here.

Something like a Consume the windows to the _left_ into the active column.

@jtaala
Copy link
Collaborator Author

jtaala commented Nov 11, 2023

I'll merge this one in and we can create an enhancement issue to add a consuming from left keybind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merging soon Label for PRs that are planned to be merged soon (usually within the next week)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

open new window to left of focused window
2 participants