Support gnome 40 and 41 #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is much more flexible: we can drag windows across workspaces in the carousel, react on keybindings, scroll, etc.
…ting workspace switch This simplifies code moving windows between workspaces without messing with the focus. (since mutter enforce focus_window.workspace == active_workspace) Mainly preparation for DnD fixes in the next commit.
- delay workspace change until DnD end (partial Navigator destroy) - sync scratch window frame with clone on grab end Bug in the wip commit fixed: (focus was not always preserved on workspace dnd) - DnD a window - switch to a different workspace using the workspace carousel - drop the window -> the DnD-window loose focus on workspace change (in step 2) Note: Mutter enforce focus_window.workspace === active_workspace, changing focus window if necessary.
Use get_pointer, and transform_stage_point for to get correct coordinates...
For some reason this is accurate
- Activate destination workspace if it isn't active, fake it if not. If a «stuck» window have focus, consider it selected. If selected window or one its transient window has focus, fake focus handler. Otherwise activate it.
Add soft fork explanation to README.md
This reverts commit 3e4dcd1.
Add workspace animation fix to kludges
Prefs: Rewrite for GTK4
Within the initial preference settings fixes, both Gtk.accelerator_parse() functions were changed to use the new GTK4.0 return values. GTK4 is only used for the preference display so this broke the keybind override function. Reverting the non-pref keybind parser to GTK3 signature fixes this.
Merge develop into next-release
Merge in README note Merging all changes from this branch, for the historical record. The readme will need to be updated after this, anyway.
fix: don't barf with a null metaWindow Context from @mskorzhinskiy in [PR #14]: > Using next-release branch of PaperWM-community on Gnome 40, I have > noticed that some of the keybindings do not work for some reason. E.g. > "Super+V", whic should open the calendar/notifications widget. Every > hit of this keybinding additionally leads to a JS stack trace in the > gnome journal. > This fix doesn't bring back the functionality, i.e. keybindigs are > still not working (I know about Super+V and Super+S), but it removes > the annoying stack trace. [PR #14]: #14
Fix "actor deprecated" warnings Context from @mskorzhinskiy in [PR #15]: > There are a lot of "actor deprecated" warnnings everywhere and I > believe previous fixes (902e8ed) of this warnings could be done > differently. > Also I have a suspicion that this fix improves instability of working > on Gnome40: before applying the fix, paperwm would crash pretty > randomly. However it may just a coincidence and effect of other > patches. I haven't tested this patch in the isolation to check that. [PR #15]: #15
fix use of deprecated source.notify() Context from [PR #21]: @cg505: > I was seeing this error when trying to enable: > > ``` > JS ERROR: Extension paperwm@hedning:matrix.org: Error: Expected type string for argument 'property_name' but got type GObject_Object > notify@$HOME/.local/share/gnome-shell/extensions/paperwm@hedning:matrix.org/extension.js:197:12 > errorNotification@$HOME/.local/share/gnome-shell/extensions/paperwm@hedning:matrix.org/extension.js:211:32 > safeCall@$HOME/.local/share/gnome-shell/extensions/paperwm@hedning:matrix.org/extension.js:64:26 > run@$HOME/.local/share/gnome-shell/extensions/paperwm@hedning:matrix.org/extension.js:49:17 > init@$HOME/.local/share/gnome-shell/extensions/paperwm@hedning:matrix.org/extension.js:98:12 > _callExtensionInit@resource:///org/gnome/shell/ui/extensionSystem.js:428:50 > loadExtension@resource:///org/gnome/shell/ui/extensionSystem.js:345:27 > _loadExtensions/<@resource:///org/gnome/shell/ui/extensionSystem.js:594:18 > collectFromDatadirs@resource:///org/gnome/shell/misc/fileUtils.js:27:28 > _loadExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:573:19 > _enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:603:18 > _sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:634:18 > init@resource:///org/gnome/shell/ui/extensionSystem.js:56:14 > _initializeUI@resource:///org/gnome/shell/ui/main.js:265:22 > start@resource:///org/gnome/shell/ui/main.js:162:5 > @resource:///org/gnome/shell/ui/init.js:6:17 > ``` > > This resolved the issue. This call was deprecated a while ago and > finally removed. See > https://gitlab.gnome.org/GNOME/gnome-shell/-/commit/16c7739170ffb0dd59f75f16d65bc8a97bd2033e. > > Honestly, I'm not really sure how none of you have run into this... > maybe just have it already enabled, so no problem. @ccope: > I ran into a notification error (maybe this was what it was?) when I > first enabled the extension, and I had to log out and back in to get > the extension to work in my wayland session, but after that it was > fine. I assume the plugin just doesn't create notifications after > installation? > > Oh right, this was the first error I reported: #20 (comment) > #20 (comment) @cg505: > Hmm, I think for me relogging didn't help for whatever reason. But it > sounds like maybe the same issue. [PR #21]: #21
Fix defined keybinds not applying correctly This is a manual merge, since some other commits were accidentally added to that PR #22
tiling: Remove topBarAdjustment from workArea
In preparation for merging back upstream
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of at least 2 PRs for getting work from the fork merged back here. It also includes the contents of the
next-releasebranch from this repo.Fixes #376
For more context/history, see: