fix: Load httpfs & Store DuckDB extensions in PGDATA
#200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippemnoel
changed the title
httpfshttpfs & Store DuckDB extensions in PGDATA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s) Closed
What
This PR solves two issues:
1- On CNPG, only the PGDATA directory is writable. This was causing issues to some of our customers and to Tembo (who also uses CNPG). By default, DuckDB stores its extension files in
/var/lib/postgresql/.duckdb, which was read-only. Instead, we retrieve the PGDATA path and set it as the extension path for DuckDB extensions.2- A previous upgrade to a newer
duckdb-rsversion brought us a version of the client that no longer bundled thehttpfsextension. We therefore load it ourselves.Why
Fix customer issues.
How
^
Tests
Need to write unit tests.