Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Load httpfs & Store DuckDB extensions in PGDATA #200

Merged
merged 9 commits into from
Jan 31, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
cargo fmt
rebasedming committed Jan 31, 2025

Verified

This commit was signed with the committer’s verified signature.
pradyunsg Pradyun Gedam
commit 75cef545ae6d98830d166e206c272f767ba694dc
5 changes: 4 additions & 1 deletion src/duckdb/connection.rs
Original file line number Diff line number Diff line change
@@ -257,7 +257,10 @@ pub fn set_search_path(search_path: Vec<String>) -> Result<()> {

pub fn set_duckdb_extension_directory(extension_directory_path: &str) -> Result<()> {
// Set duckdb extension directory
execute(format!("SET extension_directory = '{extension_directory_path}'").as_str(), [])?;
execute(
format!("SET extension_directory = '{extension_directory_path}'").as_str(),
[],
)?;

Ok(())
}
2 changes: 1 addition & 1 deletion src/fdw/base.rs
Original file line number Diff line number Diff line change
@@ -18,8 +18,8 @@
use anyhow::{anyhow, bail, Result};
use duckdb::arrow::array::RecordBatch;
use pgrx::*;
use std::ffi::CStr;
use std::collections::HashMap;
use std::ffi::CStr;
use strum::IntoEnumIterator;
use supabase_wrappers::prelude::*;
use thiserror::Error;