fix: Fixes datetime functions support #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanxg852000
changed the title
evanxg852000
force-pushed
the
fix/arrow-date-support
branch
from
81d9119 to
1d0fc36
Compare
evanxg852000
requested review from
rebasedming,
neilyio and
philippemnoel
as code owners
There was a problem hiding this comment.
@evanxg852000 could you please fix the lint? There's also some other open PR: paradedb/paradedb#1478
If we use yours, do we not need this one?
|
Fixing the lint is not a big deal, but I am doing more testing on this. |
evanxg852000
force-pushed
the
fix/arrow-date-support
branch
2 times, most recently
from
54c2e39 to
3707a5c
Compare
neilyio
reviewed
Aug 7, 2024
rebasedming
reviewed
Aug 8, 2024
evanxg852000
force-pushed
the
fix/arrow-date-support
branch
from
3707a5c to
cbf395d
Compare
rebasedming
approved these changes
Aug 10, 2024
philippemnoel
added a commit
that referenced
this pull request
Aug 12, 2024
This reverts commit 4ffcbdc.
philippemnoel
added a commit
that referenced
this pull request
Aug 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s) Closed
What
As reported in the issue, date functions like
date_trunc,date_partare not workingWhy
The
DataType::Date32andDataType::Date64were not handled forTIMESTAMPTZOID.How
Handled the case with appropriate conversions
Tests
Added a test