Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Requests type to alloy #11082

Closed
Tracked by #12576
mattsse opened this issue Sep 21, 2024 · 5 comments
Closed
Tracked by #12576

Move Requests type to alloy #11082

mattsse opened this issue Sep 21, 2024 · 5 comments
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Sep 21, 2024

Describe the feature

this type exists as a helper

reth/crates/primitives-traits/src/request.rs

Line 30 in 95d65dc

pub struct Requests(pub Vec<Request>);

because the rlp encoding is slightly different

TODO

  • move this type to alloy where Request is defined

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Sep 21, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started and removed S-needs-triage This issue needs to be labelled labels Sep 21, 2024
@mattsse mattsse mentioned this issue Sep 21, 2024
Merged
@PanGan21 PanGan21 mentioned this issue Sep 21, 2024
Merged
@0xriazaka
Copy link
Contributor

Can i take this?

@varun-doshi
Copy link
Contributor

I'd like to work on this

@PanGan21
Copy link
Contributor

I believe this issue is blocked until the next alloy release

@refcell
Copy link
Contributor

refcell commented Sep 23, 2024

Ref: alloy-rs/alloy#1326

@mattsse mattsse closed this as completed Oct 2, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Oct 2, 2024
@mattsse mattsse reopened this Oct 2, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Reth Tracker Oct 2, 2024
@varun-doshi varun-doshi mentioned this issue Oct 2, 2024
Closed
@mattsse
Copy link
Collaborator Author

mattsse commented Oct 17, 2024

with recen pectra changes this wont be necessary anymore

@mattsse mattsse closed this as completed Oct 17, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Oct 17, 2024
@emhane emhane mentioned this issue Nov 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: move Requests type to alloy varun-doshi/reth
5 participants
@mattsse @refcell @PanGan21 @varun-doshi @0xriazaka