Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move Requests type to alloy #11419

Closed
wants to merge 2 commits into from
Closed

feat: move Requests type to alloy #11419

wants to merge 2 commits into from

Conversation

varun-doshi
Copy link
Contributor

Closes #11082

Description

Moved the respective type to alloy where Request is defined

Added a test for Requests

@Rjected Rjected changed the title (feat): Move Requests type to alloy feat: move Requests type to alloy Oct 2, 2024
@onbjerg
Copy link
Member

onbjerg commented Oct 2, 2024

Imo we probably shouldn't do much here given it's being removed for devnet 4. Do you mind if I put this on hold?

@varun-doshi
Copy link
Contributor Author

Imo we probably shouldn't do much here given it's being removed for devnet 4. Do you mind if I put this on hold?

Alright
Do let me know if there are any changes required later on

@mattsse mattsse added the S-blocked This cannot more forward until something else changes label Oct 5, 2024
@mattsse
Copy link
Collaborator

mattsse commented Oct 16, 2024

requests got removed and we no longer need this

@mattsse mattsse closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

Assignees
No one assigned
Labels
S-blocked This cannot more forward until something else changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Requests type to alloy
3 participants
@varun-doshi @onbjerg @mattsse