Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky Geth integration test #3456

Closed
1 task done
shekhirin opened this issue Jun 28, 2023 · 2 comments · Fixed by #3476
Closed
1 task done

Flaky Geth integration test #3456

shekhirin opened this issue Jun 28, 2023 · 2 comments · Fixed by #3476
Assignees
@mattsse
Labels
A-networking Related to networking in general C-bug An unexpected or incorrect behavior C-test A change that impacts how or what we test

Comments

@shekhirin
Copy link
Collaborator

shekhirin commented Jun 28, 2023 •
edited
Loading

Describe the bug

https://github.com/paradigmxyz/reth/actions/runs/5405202612/jobs/9820416442?pr=3455#step:8:789

--- STDERR:              reth-network::it connect::test_incoming_node_id_blacklist ---
thread 'connect::test_incoming_node_id_blacklist' panicked at 'called `Result::unwrap()` on an `Err` value: HTTPError(reqwest::Error { kind: Request, url: Url { scheme: "http", cannot_be_a_base: false, username: "", password: None, host: Some(Ipv4(127.0.0.1)), port: Some(44187), path: "/", query: None, fragment: None }, source: hyper::Error(Connect, ConnectError("tcp connect error", Os { code: 111, kind: ConnectionRefused, message: "Connection refused" })) })', crates/net/network/tests/it/connect.rs:325:70

Code of Conduct

  • I agree to follow the Code of Conduct
@shekhirin shekhirin added C-bug An unexpected or incorrect behavior S-needs-triage This issue needs to be labelled labels Jun 28, 2023
@shekhirin shekhirin added C-test A change that impacts how or what we test A-networking Related to networking in general and removed S-needs-triage This issue needs to be labelled labels Jun 28, 2023
@mattsse
Copy link
Collaborator

mattsse commented Jun 28, 2023

this could be a port issue, or some race condition when launching geth

@Rjected Rjected mentioned this issue Jun 29, 2023
Merged
@mattsse
Copy link
Collaborator

mattsse commented Jun 29, 2023

there was a port issue:

gakonst/ethers-rs#2475

that's not included in the current ethers release

@gakonst can we bump?

@mattsse mattsse mentioned this issue Jun 29, 2023
Merged
@onbjerg onbjerg mentioned this issue Jun 29, 2023
Merged
@onbjerg onbjerg moved this from Todo to In Progress in Reth Tracker Jun 29, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattsse mattsse

Labels
A-networking Related to networking in general C-bug An unexpected or incorrect behavior C-test A change that impacts how or what we test
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: set --authrpc.port to 0 for Geth instance paradigmxyz/reth
2 participants
@shekhirin @mattsse