Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: run geth blacklist test also serial #3469

Merged
merged 1 commit into from
Jun 29, 2023
Merged

test: run geth blacklist test also serial #3469

merged 1 commit into from
Jun 29, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jun 29, 2023

ref #3456

@mattsse mattsse added C-test A change that impacts how or what we test A-networking Related to networking in general labels Jun 29, 2023
shekhirin
shekhirin approved these changes Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@shekhirin shekhirin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other Geth tests are serial, this one wasn't, we fixed it. makes sense. lgtm.

@mattsse mattsse enabled auto-merge June 29, 2023 15:40
@codecov
Copy link

codecov bot commented Jun 29, 2023 •
edited
Loading

Codecov Report

Merging #3469 (d0b96f9) into main (b7c9777) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

see 12 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.26% <ø> (+<0.01%) ⬆️
unit-tests 64.23% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 23.04% <ø> (ø)
blockchain tree 81.69% <ø> (ø)
pipeline 88.05% <ø> (ø)
storage (db) 74.17% <ø> (+0.06%) ⬆️
trie 95.64% <ø> (ø)
txpool 51.37% <ø> (ø)
networking 77.90% <ø> (-0.02%) ⬇️
rpc 58.06% <ø> (-0.02%) ⬇️
consensus 62.78% <ø> (ø)
revm 35.14% <ø> (ø)
payload builder 6.83% <ø> (ø)
primitives 88.57% <ø> (ø)

@mattsse mattsse added this pull request to the merge queue Jun 29, 2023
Merged via the queue into main with commit b0df026 Jun 29, 2023
@mattsse mattsse deleted the matt/run-black-list-test-serial branch June 29, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-networking Related to networking in general C-test A change that impacts how or what we test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @shekhirin