Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: set --authrpc.port to 0 for Geth instance #3476

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jun 29, 2023

geth fails after ~2s if the auth server is already in use however the Geth::spawn returns once the HTTP server is up.

this sets the auth.rpc port to 0 since we don't care about it

Closes #3456

@mattsse mattsse requested a review from Rjected as a code owner June 29, 2023 18:50
@mattsse mattsse added the C-test A change that impacts how or what we test label Jun 29, 2023
@mattsse mattsse requested a review from shekhirin June 29, 2023 18:50
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse enabled auto-merge June 29, 2023 18:52
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #3476 (fae4c3a) into main (f9d9387) will increase coverage by 32.08%.
The diff coverage is n/a.

Impacted file tree graph

see 294 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.26% <ø> (+1.97%) ⬆️
unit-tests 64.25% <ø> (+31.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 23.01% <ø> (+13.57%) ⬆️
blockchain tree 81.69% <ø> (+59.34%) ⬆️
pipeline 87.88% <ø> (+49.01%) ⬆️
storage (db) 74.17% <ø> (+33.02%) ⬆️
trie 95.64% <ø> (+46.93%) ⬆️
txpool 51.37% <ø> (+18.04%) ⬆️
networking 77.87% <ø> (+33.86%) ⬆️
rpc 58.13% <ø> (+23.88%) ⬆️
consensus 62.78% <ø> (+22.52%) ⬆️
revm 35.14% <ø> (+21.47%) ⬆️
payload builder 6.83% <ø> (ø)
primitives 88.69% <ø> (+40.76%) ⬆️

@mattsse mattsse added this pull request to the merge queue Jun 29, 2023
Merged via the queue into main with commit 0ec3225 Jun 29, 2023
@mattsse mattsse deleted the matt/set-auth-rpc-port-to-0 branch June 29, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-test A change that impacts how or what we test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky Geth integration test
2 participants