-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make rpc-types completely standalone #3964
Comments
Is there additional work pending for this? |
ideally we want to get rid of all the conversion/build functions in the rpc-types crate so that it only uses types like H256,U256 etc. I think we move things like: reth/crates/rpc/rpc-types/src/eth/transaction/mod.rs Lines 79 to 87 in c423514
to a new crate like rpc-types-compat or something |
https://github.com/paradigmxyz/reth/blob/main/crates/rpc/rpc-types/src/eth/transaction/signature.rs should also be moved right? |
right! |
Should TransactionSigned, Withdrawal be removed?
Also , do we want to also remove constants imported through reth_primitives? |
hmm, yeah we now need to duplicate the Withdrawal type and move the |
What next? |
done, |
Describe the feature
remove any reth/jsonrpsee dependencies from reth-rpc-types
Additional context
No response
The text was updated successfully, but these errors were encountered: