Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make rpc-types completely standalone #3964

Closed
mattsse opened this issue Jul 27, 2023 · 8 comments
Closed

make rpc-types completely standalone #3964

mattsse opened this issue Jul 27, 2023 · 8 comments
Assignees
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jul 27, 2023

Describe the feature

remove any reth/jsonrpsee dependencies from reth-rpc-types

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request A-rpc Related to the RPC implementation labels Jul 27, 2023
@mattsse mattsse self-assigned this Jul 27, 2023
@supernovahs
Copy link
Contributor

Is there additional work pending for this?

@mattsse
Copy link
Collaborator Author

mattsse commented Aug 6, 2023

ideally we want to get rid of all the conversion/build functions in the rpc-types crate so that it only uses types like H256,U256 etc.

I think we move things like:

pub fn from_recovered_with_block_context(
tx: TransactionSignedEcRecovered,
block_hash: H256,
block_number: BlockNumber,
base_fee: Option<u64>,
tx_index: U256,
) -> Self {
Self::fill(tx, Some(block_hash), Some(block_number), base_fee, Some(tx_index))
}

to a new crate like rpc-types-compat or something

@supernovahs
Copy link
Contributor

@mattsse
Copy link
Collaborator Author

mattsse commented Aug 10, 2023

right!
we also want to move this

@supernovahs
Copy link
Contributor

Should TransactionSigned, Withdrawal be removed?

Address, Block, Bloom, Bytes, Header, SealedBlock, TransactionSigned, UintTryTo, Withdrawal,
.

Also , do we want to also remove constants imported through reth_primitives?
constants::{MAXIMUM_EXTRA_DATA_SIZE, MIN_PROTOCOL_BASE_FEE_U256}

@mattsse
Copy link
Collaborator Author

mattsse commented Aug 10, 2023

hmm,

yeah we now need to duplicate the Withdrawal type and move the TryFrom impls to compat as functions I believe

@supernovahs
Copy link
Contributor

What next?

@mattsse
Copy link
Collaborator Author

mattsse commented Sep 25, 2023

done,
tysm for this

@mattsse mattsse closed this as completed Sep 25, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants