NewPooledTransactionHashes uses incorrect size for blob transactions

[Rjected]

The NewPooledTransactionHashes message we broadcast uses the following method to populate the size associated with a transaction:

reth/crates/net/network/src/transactions.rs

Lines 265 to 271 in 261a9f9

	// transaction lists, before deciding whether or not to send full transactions to the
	// peer.
	for tx in to_propagate.iter() {
	if peer.transactions.insert(tx.hash()) {
	hashes.push(tx);
	// Do not send full 4844 transaction hashes to peers.

with implementation:

reth/crates/net/network/src/transactions.rs

Lines 733 to 744 in 261a9f9

	fn push(&mut self, tx: &PropagateTransaction) {
	match self {
	PooledTransactionsHashesBuilder::Eth66(msg) => msg.0.push(tx.hash()),
	PooledTransactionsHashesBuilder::Eth68(msg) => {
	msg.hashes.push(tx.hash());
	msg.sizes.push(tx.size);
	msg.types.push(tx.transaction.tx_type().into());
	}
	}
	}

This uses PropagateTransaction which only computes the size based on the TransactionSigned::length. This is not accurate for blob transactions, which must account for the length of the BlobSidecar as well, i.e. the PooledTransactionsElement length is more appropriate.

[mattsse]

nice find, this requires two fixes,

set accordingly when the tx is created with blob, and update length by fetching from blobstore during validation (re-injected transactions)