Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use cached encoded length #4577

Merged
merged 2 commits into from
Sep 13, 2023
Merged

fix: use cached encoded length #4577

merged 2 commits into from
Sep 13, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 13, 2023

Closes #4571

uses the cached rlp encoded length for the size

@mattsse mattsse requested a review from Rjected as a code owner September 13, 2023 12:18
@mattsse mattsse added C-perf A change motivated by improving speed, memory usage or disk footprint A-networking Related to networking in general labels Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023 •
edited
Loading

Codecov Report

Merging #4577 (565b506) into main (48b75e0) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/net/network/src/transactions.rs 61.54% <0.00%> (+0.41%) ⬆️

... and 10 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.64% <0.00%> (-0.01%) ⬇️
unit-tests 63.99% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.85% <ø> (ø)
blockchain tree 83.58% <ø> (ø)
pipeline 90.52% <ø> (-0.02%) ⬇️
storage (db) 75.32% <ø> (ø)
trie 94.84% <ø> (-0.04%) ⬇️
txpool 48.68% <ø> (-0.49%) ⬇️
networking 77.21% <0.00%> (+0.02%) ⬆️
rpc 57.29% <ø> (ø)
consensus 63.40% <ø> (ø)
revm 31.56% <ø> (ø)
payload builder 6.12% <ø> (ø)
primitives 86.53% <ø> (-0.01%) ⬇️

Rjected
Rjected approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, LGTM

@mattsse mattsse added this pull request to the merge queue Sep 13, 2023
Merged via the queue into main with commit c831d30 Sep 13, 2023
@mattsse mattsse deleted the matt/calc-tx-size-correctly3 branch September 13, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

Assignees
No one assigned
Labels
A-networking Related to networking in general C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NewPooledTransactionHashes uses incorrect size for blob transactions
2 participants
@mattsse @Rjected