Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: calc blob tx size correctly #4576

Closed
wants to merge 1 commit into from
Closed

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 13, 2023

Closes #4571

This could be improved by caching the rlp size once when creating the Validated transaction as suggested in

#4571 (comment)

@mattsse mattsse requested a review from Rjected as a code owner September 13, 2023 12:09
@mattsse mattsse added C-bug An unexpected or incorrect behavior A-networking Related to networking in general E-cancun Related to the Cancun network upgrade labels Sep 13, 2023
@mattsse mattsse closed this Sep 13, 2023
@onbjerg onbjerg deleted the matt/calc-tx-size-correctly2 branch December 15, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-networking Related to networking in general C-bug An unexpected or incorrect behavior E-cancun Related to the Cancun network upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NewPooledTransactionHashes uses incorrect size for blob transactions
1 participant