refactor(trie): remove dependency on reth-db and reth-db-api
#10008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanHodulak
requested review from
rkrasiuk,
Rjected and
gakonst
as code owners
RomanHodulak
force-pushed
the
romanhodulak/remove-trie-db-dep
branch
from
953ab2e to
fe8e6c6
Compare
gakonst
approved these changes
Aug 1, 2024
|
@gakonst Definitely |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This PR removes unused dependencies in
reth-triecrate.Motivation
Expanding on #9282, the
reth-dbis now an unused dependency inreth-trieGoals
reth-dbandreth-db-apifromreth-trieSolution
reth-dbandreth-db-apifrom Cargo.toml ofreth-trie(including dev)DatabaseErrorusage inreth-trieAdditional notes
The moment you've been waiting for.
Closes #9282