chore(sdk): SealedBlock generic over header and body
#11430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
added
C-debt
emhane
requested review from
onbjerg,
rkrasiuk,
shekhirin,
Rjected and
joshieDo
as code owners
joshieDo
reviewed
Oct 2, 2024
mattsse
reviewed
Oct 3, 2024
| #[derive(Debug, Clone, PartialEq, Eq, Default, Serialize, Deserialize, Deref, DerefMut)] | ||
| pub struct SealedBlock { | ||
| #[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize, Deref, DerefMut)] | ||
| pub struct SealedBlock<H = Header, B = BlockBody> { |
There was a problem hiding this comment.
having to generics here is likely not convenient, ideally this should use the Block trait
There was a problem hiding this comment.
SealedBlock is a return type in signature of Block trait
|
please link the other prs, it's easy to miss |
|
end goal is to move to |
Is this blocking any PRs or issues right now? If so, what's being blocked? |
yes, it isn't possible to plug in the |
emhane
commented
Oct 7, 2024
github-actions
bot
added
the
S-stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
SealedBlocktype definition generic over header and body type, which is a necessary first step to useSealedBlockinBlocktrait method signatures