Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: record selfdstructs properly #3921

Merged
merged 6 commits into from
Aug 1, 2023
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 26, 2023

closes #3919

selfdestructs are no separate call so the way we convert to parity action is likely wrong because this swallows the call action

Selfdestructs need to be derived from the call that triggered and are additional trace objects

this adds an iterator type that can handle this

@mattsse mattsse added the A-rpc Related to the RPC implementation label Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #3921 (92dd7b9) into main (73652ed) will decrease coverage by 0.06%.
Report is 7 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
...revm/revm-inspectors/src/tracing/builder/parity.rs 0.00% <0.00%> (ø)
crates/revm/revm-inspectors/src/tracing/types.rs 0.00% <0.00%> (ø)

... and 11 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.32% <0.00%> (-0.02%) ⬇️
unit-tests 64.27% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.67% <ø> (ø)
blockchain tree 83.04% <ø> (ø)
pipeline 89.82% <ø> (ø)
storage (db) 74.30% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 45.40% <ø> (ø)
networking 77.63% <ø> (-0.04%) ⬇️
rpc 58.52% <ø> (+0.01%) ⬆️
consensus 63.51% <ø> (ø)
revm 32.71% <0.00%> (-0.38%) ⬇️
payload builder 6.58% <ø> (ø)
primitives 87.92% <ø> (-0.02%) ⬇️

@onbjerg onbjerg added C-bug An unexpected or incorrect behavior M-changelog This change should be included in the changelog labels Jul 26, 2023
@onbjerg
Copy link
Member

onbjerg commented Jul 26, 2023

Is #3863 related to #3919?

@mattsse
Copy link
Collaborator Author

mattsse commented Jul 26, 2023

could be the same issue

I'd actually say likely because this affects all selfdestruct calls

@mattsse mattsse changed the title wip fix: record selfdstructs properly fix: record selfdstructs properly Jul 31, 2023
@mattsse mattsse marked this pull request as ready for review July 31, 2023 13:27
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Aug 1, 2023
Merged via the queue into main with commit 4b0f4ec Aug 1, 2023
@mattsse mattsse deleted the matt/investigate-selfdestruct branch August 1, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior M-changelog This change should be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect result of trace_transaction
3 participants