-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: record selfdstructs properly #3921
Conversation
Codecov Report
... and 11 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
could be the same issue I'd actually say likely because this affects all selfdestruct calls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
closes #3919
selfdestructs are no separate call so the way we convert to parity action is likely wrong because this swallows the call action
Selfdestructs need to be derived from the call that triggered and are additional trace objects
this adds an iterator type that can handle this