dev: use U64 for transaction_index
#4261
Conversation
ftupas
force-pushed
the
dev/skip-serialize-transactionreceipt
branch
from
1d41342
to
43b5664
Compare
| /// Address of the receiver. None when it's a contract creation transaction. | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub to: Option<Address>, |
There was a problem hiding this comment.
I think this should be null for creations, but it could be that some clients differ
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub transaction_index: Option<U256>, |
There was a problem hiding this comment.
this should actually not be an Option at all.
so we should change this to U64 probably
Gotcha, thanks for the review! I've updated the pr to use u64 and remove the skip |
ftupas
changed the title
Nonetransaction_index
| @@ -9,7 +9,7 @@ pub struct TransactionReceipt { | |||
| /// Transaction Hash. | |||
| pub transaction_hash: Option<H256>, | |||
| /// Index within the block. | |||
| pub transaction_index: Option<U256>, | |||
| pub transaction_index: u64, | |||
There was a problem hiding this comment.
this should be U64 because should be hex
There was a problem hiding this comment.
Gotcha makes sense, thanks! Just changed it to U64 🙂
ftupas
force-pushed
the
dev/skip-serialize-transactionreceipt
branch
from
2697737
to
011dd8d
Compare
ftupas
changed the title
transaction_indextransaction_index
Codecov Report
... and 12 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Hello, this smol pr does the following
add skipping of serialization fortransaction_indexandtotransaction_indexTransactionReceiptfieldtransaction_indexis set toNone#4260