Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove outdated TODOs #4498

Merged
merged 1 commit into from
Sep 6, 2023
Merged

chore: remove outdated TODOs #4498

merged 1 commit into from
Sep 6, 2023

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Sep 6, 2023

These were fixed by #4400 and #4417

@Rjected Rjected added C-debt Refactor of code section that is hard to understand or maintain A-rpc Related to the RPC implementation A-consensus Related to the consensus engine labels Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023 •
edited
Loading

Codecov Report

Merging #4498 (db5bfb2) into main (422d930) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

Files Changed Coverage Δ
crates/payload/builder/src/payload.rs 0.00% <ø> (ø)
crates/rpc/rpc-engine-api/src/engine_api.rs 80.27% <ø> (+0.15%) ⬆️

... and 12 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.71% <ø> (-0.02%) ⬇️
unit-tests 63.84% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 29.71% <ø> (ø)
blockchain tree 83.58% <ø> (ø)
pipeline 90.56% <ø> (ø)
storage (db) 75.06% <ø> (ø)
trie 94.88% <ø> (ø)
txpool 47.50% <ø> (ø)
networking 77.46% <ø> (-0.07%) ⬇️
rpc 57.45% <ø> (+<0.01%) ⬆️
consensus 63.40% <ø> (ø)
revm 31.74% <ø> (ø)
payload builder 6.34% <ø> (ø)
primitives 86.32% <ø> (ø)

@mattsse mattsse added this pull request to the merge queue Sep 6, 2023
Merged via the queue into main with commit e6f933d Sep 6, 2023
24 checks passed
@mattsse mattsse deleted the dan/remove-solved-todos branch September 6, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
A-consensus Related to the consensus engine A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rjected @mattsse