Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only accept rpc enveloped format for transactions in payload #4928

Merged
merged 3 commits into from
Oct 6, 2023

add docs on decoding and Header::decode quirk

1e24d8a
Select commit
Loading
Failed to load commit list.
Merged

fix: only accept rpc enveloped format for transactions in payload #4928

add docs on decoding and Header::decode quirk
1e24d8a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 6, 2023 in 0s

67.64% (+0.17%) compared to 442f28a

View this Pull Request on Codecov

67.64% (+0.17%) compared to 442f28a

Details

Codecov Report

Merging #4928 (1e24d8a) into main (442f28a) will increase coverage by 0.17%.
Report is 6 commits behind head on main.
The diff coverage is 90.80%.

Impacted file tree graph

Files Coverage Δ
crates/primitives/src/transaction/mod.rs 75.31% <ø> (+0.34%) ⬆️
crates/primitives/src/transaction/pooled.rs 62.03% <ø> (ø)
crates/payload/builder/src/payload.rs 0.00% <0.00%> (ø)
crates/rpc/rpc-types-compat/src/engine/payload.rs 76.57% <92.94%> (+29.10%) ⬆️

... and 29 files with indirect coverage changes

Components Coverage Δ
reth binary 33.00% <ø> (-0.02%) ⬇️
blockchain tree 80.63% <ø> (ø)
pipeline 88.45% <ø> (ø)
storage (db) 74.43% <ø> (ø)
trie 94.48% <ø> (-0.04%) ⬇️
txpool 48.52% <ø> (-0.86%) ⬇️
networking 76.23% <ø> (+0.10%) ⬆️
rpc 58.41% <92.94%> (+0.67%) ⬆️
consensus 63.01% <ø> (+1.96%) ⬆️
revm 28.47% <ø> (ø)
payload builder 8.15% <0.00%> (ø)
primitives 85.47% <ø> (+0.06%) ⬆️