Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): enable eth_getProof #5071

Merged
merged 4 commits into from
Oct 18, 2023
Merged

feat(rpc): enable eth_getProof #5071

merged 4 commits into from
Oct 18, 2023

Conversation

rkrasiuk
Copy link
Member

Description

Enable eth_getProof for the latest block.

@rkrasiuk rkrasiuk added C-enhancement New feature or request A-rpc Related to the RPC implementation labels Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #5071 (9a78442) into main (4b1a0ce) will increase coverage by 0.05%.
Report is 3 commits behind head on main.
The diff coverage is 77.90%.

Impacted file tree graph

Files Coverage Δ
crates/consensus/beacon/src/engine/mod.rs 73.34% <ø> (ø)
crates/rpc/rpc-builder/src/eth.rs 83.87% <ø> (ø)
crates/rpc/rpc-types/src/eth/account.rs 85.18% <ø> (ø)
crates/rpc/rpc/src/eth/api/mod.rs 61.19% <100.00%> (ø)
crates/rpc/rpc/src/eth/api/state.rs 80.18% <100.00%> (+29.78%) ⬆️
crates/rpc/rpc/src/eth/api/transactions.rs 33.49% <100.00%> (ø)
crates/rpc/rpc/src/trace.rs 42.03% <100.00%> (ø)
...tes/storage/provider/src/providers/state/macros.rs 100.00% <ø> (ø)
crates/storage/provider/src/test_utils/noop.rs 30.88% <100.00%> (+1.61%) ⬆️
crates/storage/provider/src/traits/state.rs 40.67% <ø> (+13.55%) ⬆️
... and 12 more

... and 14 files with indirect coverage changes

Flag Coverage Δ
integration-tests 17.09% <66.27%> (+0.07%) ⬆️
unit-tests 62.39% <16.27%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.90% <ø> (+0.05%) ⬆️
blockchain tree 80.82% <ø> (ø)
pipeline 88.38% <ø> (ø)
storage (db) 74.64% <33.33%> (+0.22%) ⬆️
trie 94.93% <ø> (-0.07%) ⬇️
txpool 55.33% <ø> (-0.45%) ⬇️
networking 78.20% <ø> (+0.01%) ⬆️
rpc 58.49% <83.33%> (+0.26%) ⬆️
consensus 63.01% <ø> (ø)
revm 28.73% <0.00%> (+0.03%) ⬆️
payload builder 7.95% <ø> (ø)
primitives 86.41% <ø> (+0.03%) ⬆️

crates/rpc/rpc-types/src/eth/account.rs Outdated Show resolved Hide resolved
crates/rpc/rpc/src/eth/api/server.rs Show resolved Hide resolved
crates/rpc/rpc/src/eth/api/server.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Oct 18, 2023
Merged via the queue into main with commit 3adc627 Oct 18, 2023
23 checks passed
@mattsse mattsse deleted the rkrasiuk/rpc-enable-get-proof branch October 18, 2023 16:20
mattsse pushed a commit that referenced this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants