Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes #5191

Merged
merged 22 commits into from
Feb 29, 2024
Merged

Breaking changes #5191

merged 22 commits into from
Feb 29, 2024

Conversation

shekhirin
Copy link
Collaborator

Umbrella PR for all breaking changes. Do not merge until the breaking release.

@shekhirin shekhirin added the S-breaking This PR includes a breaking change label Oct 26, 2023
@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Dec 15, 2023
@github-actions github-actions bot closed this Dec 23, 2023
@Rjected Rjected added M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity and removed S-stale This issue/PR is stale and will close with no further activity labels Dec 23, 2023
@Rjected Rjected reopened this Dec 23, 2023
shekhirin and others added 9 commits January 9, 2024 13:50
Co-authored-by: joshieDo <93316087+joshieDo@users.noreply.github.com>
Co-authored-by: Bjerg <onbjerg@users.noreply.github.com>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Co-authored-by: Oliver Nordbjerg <hi@notbjerg.me>
Co-authored-by: joshieDo <ranriver@protonmail.com>
Co-authored-by: Thomas Coratger <thomas.coratger@gmail.com>
@joshieDo joshieDo marked this pull request as ready for review February 27, 2024 20:54
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets do this

can we also add a note to the readme

@shekhirin shekhirin added this pull request to the merge queue Feb 29, 2024
Merged via the queue into main with commit 6b5b6f7 Feb 29, 2024
30 checks passed
@shekhirin shekhirin deleted the breaking-changes branch February 29, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity S-breaking This PR includes a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants