-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking changes #5191
Merged
Merged
Breaking changes #5191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-stale
This issue/PR is stale and will close with no further activity
label
Dec 15, 2023
Rjected
added
M-prevent-stale
Prevents old inactive issues/PRs from being closed due to inactivity
and removed
S-stale
This issue/PR is stale and will close with no further activity
labels
Dec 23, 2023
shekhirin
force-pushed
the
breaking-changes
branch
from
January 9, 2024 11:52
ed5686f
to
5757bc0
Compare
Co-authored-by: joshieDo <93316087+joshieDo@users.noreply.github.com> Co-authored-by: Bjerg <onbjerg@users.noreply.github.com> Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> Co-authored-by: Oliver Nordbjerg <hi@notbjerg.me> Co-authored-by: joshieDo <ranriver@protonmail.com> Co-authored-by: Thomas Coratger <thomas.coratger@gmail.com>
joshieDo
requested review from
onbjerg,
gakonst,
DaniPopes,
joshieDo,
rakita,
rkrasiuk and
mattsse
as code owners
February 27, 2024 20:54
mattsse
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets do this
can we also add a note to the readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
M-prevent-stale
Prevents old inactive issues/PRs from being closed due to inactivity
S-breaking
This PR includes a breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Umbrella PR for all breaking changes. Do not merge until the breaking release.